Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn display set list of cards into table #3125

Merged
merged 35 commits into from
Jan 18, 2024
Merged

Conversation

amickan
Copy link
Contributor

@amickan amickan commented Dec 8, 2023

This PR turns the display set list of cards into a table and adds a seperate update view.

New list view:
image

Update view:
image

Closes #3042
Part of https://github.com/DIAGNijmegen/rse-roadmap/issues/274

@amickan amickan requested a review from jmsmkn as a code owner December 8, 2023 13:57
@amickan amickan marked this pull request as draft December 8, 2023 13:57
@amickan amickan marked this pull request as ready for review December 11, 2023 15:16
@chrisvanrun
Copy link
Contributor

Post merge / release don't forget to update: https://grand-challenge.org/documentation/define-your-cases/

@jmsmkn jmsmkn removed their assignment Jan 11, 2024
@amickan amickan assigned amickan and unassigned amickan Jan 12, 2024
@amickan amickan assigned jmsmkn and unassigned amickan Jan 17, 2024
@jmsmkn jmsmkn removed their assignment Jan 18, 2024
Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@amickan amickan merged commit a110e87 into main Jan 18, 2024
8 checks passed
@amickan amickan deleted the display_set_cards_to_table branch January 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear when uploading for a DisplaySet fails
3 participants