Validation errors on job creation are not handled #3139
Comments
|
We are seeing this a lot, important to fix. |
|
PR to fix this for archive items is about ready, but for algorithm jobs I was hoping to get the open PR from before Christmas merged first because it is contingent on it. I can also make a quick fix if necessary in the meantime, but it won't use the same code as display sets and archive items (yet) then. |
|
OK, no need to do something separate, I'll review #3125 as soon as I can. |
|
New one for DICOM data that are uploaded with Patient Sex = U, which is invalid DICOM: https://grand-challenge.sentry.io/issues/4997160349/?project=303639&query=%21logger%3Acsp+is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=1 |
|
I have a big PR that touches on algorithm job creation right now, so best to hold off a few days on a fix for this. |
|
Good that say that. I was just going to start looking at this. |
This PR refactors the job creation code. Jobs, archive items and display sets now all use the same creation and validation logic. Errors from asynchronous input validation now get caught and are reported back to the user as error message on the Job object. The job is then cancelled and not executed. This PR also enables selecting existing images and files for jobs through the UI and enables re-using CIVs for existing values if possible. The same holds partially for the API view as well. It is not yet possible to create a job through the API with an existing non-image file. This was out of scope for this PR (DIAGNijmegen/rse-roadmap#335 (comment)) Part of DIAGNijmegen/rse-roadmap#335 Closes #3139 Closes #3325 Closes #3565 Partially addresses #3368 --------- Co-authored-by: James Meakin <[email protected]>
https://grand-challenge.sentry.io/issues/4667838707/?project=303639&query=%21logger%3Acsp+is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=0
The text was updated successfully, but these errors were encountered: