perf: avoid unnecessary error maps

[xuxucode]

Since defaultErrorMap and getErrorMap() may return the same one, leads to duplicate in ZodErrorMap array. And error mapping can be totally skipped if check message is provided.

https://github.com/colinhacks/zod/blob/master/src/errors.ts#L4-L5

import defaultErrorMap from "./locales/en";
import type { ZodErrorMap } from "./ZodError";

let overrideErrorMap = defaultErrorMap;
+export { defaultErrorMap };

export function setErrorMap(map: ZodErrorMap) {
  overrideErrorMap = map;
}

+export function getErrorMap() {
  return overrideErrorMap;
}

[netlify]

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

Name	Link
🔨 Latest commit	d0e8a13
🔍 Latest deploy log	https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6619dbb6ad5fb1000880bd67
😎 Deploy Preview	https://deploy-preview-2532--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[adamsujeta]

This solves my issue. Thank you! but it causes some other problems if there is no custom ErrorMap defined. Test examples:

test("too small error with custom error map and custom message", () => {
        try {
            z.string().nonempty("nonempty").parse("", {
                errorMap: () => {
                    return {message: "override"}
                }
            })
        } catch
            (err) {
            const zerr: z.ZodError = err as any;

            expect(zerr.issues[0].code).toEqual(z.ZodIssueCode.too_small);
            expect(zerr.issues[0].message).toEqual(`override`);
        }
    }
);
// this test fails
test("too small error with no custom error map and custom message", () => {
        try {
            z.string().nonempty("nonempty").parse("")
        } catch
            (err) {
            const zerr: z.ZodError = err as any;

            expect(zerr.issues[0].code).toEqual(z.ZodIssueCode.too_small);
            expect(zerr.issues[0].message).toEqual(`nonempty`);
        }
    }
);

It also breaks some test in the error.test.ts file.

[xuxucode]

@adamsujeta This PR is indent on performance only, it should be backward compatible.

For your test cases, they have different result on my local environment:

Nodejs v20.1.0
Zod 3.21.4

 ❯ src/zod-pr-2532.test.ts (2)
   × too small error with custom error map and custom message
   ✓ too small error with no custom error map and custom message

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/zod-pr-2532.test.ts > too small error with custom error map and custom message
AssertionError: expected 'nonempty' to deeply equal 'override'

- Expected
+ Received

- nonempty
+ override

 ❯ src/zod-pr-2532.test.ts:16:38
     14| 
     15|       expect(zerr.issues[0].code).toEqual(z.ZodIssueCode.too_small)
     16|       expect(zerr.issues[0].message).toEqual('override')
       |                                      ^
     17|   }
     18| },

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed (1)
      Tests  1 failed | 1 passed (2)

And the result is as expected. In your first test case, the provided error message nonempty has higher priority over any error maps. See https://github.com/colinhacks/zod/blob/master/src/helpers/parseUtil.ts#L31

[adamsujeta]

Yes you are right. I messed up in line 19 let errorMessage = issueData.message || ""; and on my machine initialized the variable with an empty string. Sorry for the confusion.

Ehhhh if this is the intended behavior, than for me it causes some issues because I wanted to translate everything in the error Map function and set only the keys to the translations in schema, but if it is so then I need to deal with it in another way.

Thank you for your help and sorry again.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[colinhacks]

Thanks for the work on this @xuxucode! This is a great fix.

Zod's current approach to error maps is pretty dumb as you probably noticed. Big changes coming in Zod 4.

[colinhacks]

This has landed in Zod 3.23.

https://github.com/colinhacks/zod/releases/tag/v3.23.0