perf: avoid unnecessary error maps (#2532)

* perf: avoid unnecessary error maps * Clean up * Support falsy errorMessage --------- Co-authored-by: Colin McDonnell <[email protected]>
colinhacks · Apr 13, 2024 · 3575727 · 3575727
1 parent 6d6ab29
commit 3575727
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/deno/lib/helpers/parseUtil.ts b/deno/lib/helpers/parseUtil.ts
@@ -16,6 +16,14 @@ export const makeIssue = (params: {
     path: fullPath,
   };
 
+  if (issueData.message !== undefined) {
+    return {
+      ...issueData,
+      path: fullPath,
+      message: issueData.message,
+    };
+  }
+
   let errorMessage = "";
   const maps = errorMaps
     .filter((m) => !!m)
@@ -28,7 +36,7 @@ export const makeIssue = (params: {
   return {
     ...issueData,
     path: fullPath,
-    message: issueData.message ?? errorMessage,
+    message: errorMessage,
   };
 };
 
@@ -65,15 +73,16 @@ export function addIssueToContext(
   ctx: ParseContext,
   issueData: IssueData
 ): void {
+  const overrideMap = getErrorMap();
   const issue = makeIssue({
     issueData: issueData,
     data: ctx.data,
     path: ctx.path,
     errorMaps: [
       ctx.common.contextualErrorMap, // contextual error map is first priority
       ctx.schemaErrorMap, // then schema-bound map if available
-      getErrorMap(), // then global override map
-      defaultErrorMap, // then global default map
+      overrideMap, // then global override map
+      overrideMap === defaultErrorMap ? undefined : defaultErrorMap, // then global default map
     ].filter((x) => !!x) as ZodErrorMap[],
   });
   ctx.common.issues.push(issue);

diff --git a/src/helpers/parseUtil.ts b/src/helpers/parseUtil.ts
@@ -16,6 +16,14 @@ export const makeIssue = (params: {
     path: fullPath,
   };
 
+  if (issueData.message !== undefined) {
+    return {
+      ...issueData,
+      path: fullPath,
+      message: issueData.message,
+    };
+  }
+
   let errorMessage = "";
   const maps = errorMaps
     .filter((m) => !!m)
@@ -28,7 +36,7 @@ export const makeIssue = (params: {
   return {
     ...issueData,
     path: fullPath,
-    message: issueData.message ?? errorMessage,
+    message: errorMessage,
   };
 };
 
@@ -65,15 +73,16 @@ export function addIssueToContext(
   ctx: ParseContext,
   issueData: IssueData
 ): void {
+  const overrideMap = getErrorMap();
   const issue = makeIssue({
     issueData: issueData,
     data: ctx.data,
     path: ctx.path,
     errorMaps: [
       ctx.common.contextualErrorMap, // contextual error map is first priority
       ctx.schemaErrorMap, // then schema-bound map if available
-      getErrorMap(), // then global override map
-      defaultErrorMap, // then global default map
+      overrideMap, // then global override map
+      overrideMap === defaultErrorMap ? undefined : defaultErrorMap, // then global default map
     ].filter((x) => !!x) as ZodErrorMap[],
   });
   ctx.common.issues.push(issue);