Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get CoinbaseSmartContractFactory and ERC1271 to 100% coverage #37

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Get CoinbaseSmartContractFactory and ERC1271 to 100% coverage #37

merged 5 commits into from
Mar 19, 2024

Commits on Mar 19, 2024

  1. Add missing tests for Factory and ERC1271, coverage doesnt pick these up

    @stevieraykatz
    stevieraykatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1335499 View commit details
    Browse the repository at this point in the history

  2. get SmartContractFactory to 100%

    @stevieraykatz
    stevieraykatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    46a65fb View commit details
    Browse the repository at this point in the history

  3. Remove console logging

    @stevieraykatz
    stevieraykatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7a50042 View commit details
    Browse the repository at this point in the history

  4. Update test/CoinbaseSmartWalletFactory.t.sol 

    Co-authored-by: wilsoncusack <[email protected]>
    @stevieraykatz @wilsoncusack
    stevieraykatz and wilsoncusack authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    019debe View commit details
    Browse the repository at this point in the history

  5. Fix test name

    @stevieraykatz
    stevieraykatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    78b28bf View commit details
    Browse the repository at this point in the history