Get CoinbaseSmartContractFactory and ERC1271 to 100% coverage #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an ongoing effort to achieve 100% coverage for all contracts in this repo...
CoinbaseSmartContractFactory
initCodeHash()
createAccount
for cases when the account has already been intitialized and another case wherein the account cannot be initialized because of malformed owner bytes.ERC1271
Currently, foundry coverage doesn't like the fact that we return the return-declared
salt
andextensions
. Adding an explicit check that the return values match the uninitialized args doesn't tick the coverage box. However, in uncommitted changes (shown below), explicitly defining the values ofsalt
andextensions
gets this test to pass with "full coverage". Since explicitly declaring these variables (again) adds ~50 gas, we shouldn't make the change just for the sake of the coverage report.Bug reported to foundry: foundry-rs/foundry#7476
Coverage report as of this PR: