Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Foundry-related configuration #271

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

gabrielstoica
Copy link
Contributor

What changed? Why?

  1. Fix typo in foundry.toml file.
  2. Add url param to Etherscan config as per Foundry documentation. Upon running forge script script/BuyMeACoffee.s.sol --rpc-url base_sepolia we'll get the following error: "At least one of 'url' or 'chain' must be present for Etherscan config with unknown alias 'base_sepolia'", hence adding the url of the explorer will fix it.
  3. Use the base_sepolia alias directly in the TOML file instead of referencing it to avoid any errors.

@gabrielstoica gabrielstoica changed the title Fix foundry-related configuration Fix Foundry-related configuration Jan 24, 2024
@Zizzamia Zizzamia requested a review from Sneh1999 January 24, 2024 20:17
template/contracts/foundry.toml Outdated Show resolved Hide resolved
template/contracts/.env.example Outdated Show resolved Hide resolved
@gabrielstoica
Copy link
Contributor Author

gabrielstoica commented Jan 28, 2024

Hi @Zizzamia, @Sneh1999!
Base Mainnet, Base Goerli and Base Sepolia now have aliases that can be used directly in the foundry.toml file. This also eliminates the need to append --etherscan-api-key ${BLOCK_EXPLORER_API_KEY} to each forge script call.

FYI: alloy-rs/chains#32 and foundry-rs/foundry#6905

Copy link
Contributor

@Sneh1999 Sneh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @gabrielstoica great work and thanks again for the contribution.

@gabrielstoica
Copy link
Contributor Author

Thanks @Sneh1999, happy to contribute!

@Zizzamia Zizzamia merged commit 9833ecb into coinbase:main Jan 29, 2024
3 of 4 checks passed
@Zizzamia
Copy link
Contributor

Brilliant!
Thank you @gabrielstoica @mattsse @DaniPopes and @Evalir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants