Add aliases for Base, BaseSepolia and BaseGoerli

[gabrielstoica]

Motivation

There are no aliases set for Base Mainnet, Base Sepolia and Base Goerli.

Solution

Add aliases for Base, BaseGoerli and BaseSepolia and related tests.

[DaniPopes]

Thanks!

[DaniPopes]

Wait, the JSON file has not updated, are you sure this does anything? It looks to me that the aliases are the exact same as the default serialization done by Serde (snake_case) and Strum (kebab-case).

[gabrielstoica]

Shouldn't this set the aliases so they can be used direcly in the foundry.toml file? e.g.

[etherscan]
base = { key = "${API_KEY_BASE}" }
base_goerli = { key = "${API_KEY_BASE}" }
base_sepolia = { key = "${API_KEY_BASE}" }

[DaniPopes]

Yes, but those are the default values which are already valid, see:

chains/assets/chains.json

Lines 471 to 473 in 534bb02

	"8453": {
	"internalId": "Base",
	"name": "base",

[gabrielstoica]

Indeed, when verifying a contract and passing the chain as --chain base-sepolia everything works, but when trying to run a script having that foundry.toml configuration file and providing the RPC URL as --rpc-url base_sepolia, I'm getting At least one of 'url' or 'chain' must be present for Etherscan config with unknown alias 'base_sepolia'.
Thought this will fix the error. Correct me if I'm wrong.

[mattsse]

@DaniPopes I've added more serde kebab cases aliases

and tests

[gabrielstoica]

@mattsse Shouldn't all aliases also have a snake case format?

[mattsse]

this is the default for serde