Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to [email protected] and load FileSaver from npm instead of bower. #4

Merged
merged 2 commits into from
Sep 19, 2017

Conversation

GCheung55
Copy link

Fix for #3.

@GCheung55
Copy link
Author

@panthony I've tried running npm test, which runs ember try:each but it seems to fail with an error I don't understand: https://gist.github.com/GCheung55/dd3275f50d79b5cf5f18a8fcf47bc97c

Running ember test is just fine. Seems to fail to run with [email protected]. Can you give this a shot? Maybe it's just my machine.

@GCheung55
Copy link
Author

I found the problem. I cloned the repo into a directory that has a name with spaces and parens. Ref: TryGhost/Ghost#3206 (comment)

Moving the directory somewhere else is working for me now.

@jrr
Copy link

jrr commented Sep 19, 2017

@panthony can this be merged/released? I'm currently referencing a copy of GCheung55's branch in my project, and I'd like to switch back to upstream.

@panthony panthony merged commit b8cd3db into cogniteev:master Sep 19, 2017
@panthony
Copy link
Member

@GCheung55 @jrr I published a new version (1.0.0) with this PR, thanks for the contribution and sorry for the unresponsiveness I got back from holidays yesterday I have a lot on my plate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants