grunt init bower task fails if space in directory name (and as a result /ghost/signup page appears blank)

[jamesmartinduffy]

Hey guys,

Just cloned a fresh copy of the repo to start on some theme development, and ran into this issue. Basically after following the install steps and navigating to /ghost/signup, I was served with a blank page. After looking into it, it appears to be caused by grunt init's "shell:bower" task failing due to my local directory having a space in it.

$ grunt init -v

...

Running "shell:bower" (shell) task
Verifying property shell.bower exists in config...OK
File: [no files]
Options: stdout, stderr=false, stdin, failOnError=false
Command: /Users/jamesduffy/Dropbox (Personal)/_Development/duffx.com/node_modules/.bin/bower install
Options: stdout, stderr=false, stdin, failOnError=false
/bin/sh: -c: line 0: syntax error near unexpected token `Personal'
/bin/sh: -c: line 0: `/Users/jamesduffy/Dropbox (Personal)/_Development/duffx.com/node_modules/.bin/bower install'

After moving the file to a directory with no space, grunt init works fine.

Not sure if it's within the Ghost team's power to fix or if this is an issue with the bower module, but figured I'd open an issue in case other people are having this problem in the future.

[novaugust]

Man, awesome, thanks for figuring this out. We just had someone come into IRC because their bower init never worked; this was almost certainly the problem.

Cheers

[ErisDS]

I thought we had this fixed, seems it was broken on Windows still. I have a fix which I'm currently testing cross platform.

@jamesmartinduffy just an FYI, when raising issues please include details of your environment. To help you know what sort of info to include we have a bug reporting template in the contributing guidelines.

[jamesmartinduffy]

Sorry – this is running locally on OS X 10.9.4, node v0.10.21, and Ghost 0.4.2.

[jamesmartinduffy]

This did not fix it for me.

Running "shell:bower" (shell) task
Verifying property shell.bower exists in config...OK
File: [no files]
Options: stdout, stderr, stdin, failOnError
Command: /Users/jamesduffy/Dropbox\ (Personal)/_Development/Ghost/node_modules/.bin/bower --allow-root install
/bin/sh: -c: line 0: syntax error near unexpected token `Personal'
/bin/sh: -c: line 0: `/Users/jamesduffy/Dropbox\ (Personal)/_Development/Ghost/node_modules/.bin/bower --allow-root install'
Warning: Command failed: /bin/sh: -c: line 0: syntax error near unexpected token `Personal'
/bin/sh: -c: line 0: `/Users/jamesduffy/Dropbox\ (Personal)/_Development/Ghost/node_modules/.bin/bower --allow-root install'
 Use --force to continue.

Aborted due to warnings.

Same error. Perhaps its due to having parentheses in the path?

I just pulled the latest, last commit is bf3078c, Ghost version 0.5.0-rc2. Again, I'm on OSX 10.9.4.

[sebgie]

I have tested on OSX 10.9.4 and it shows the following output:

Running "init" task

Running "shell:bower" (shell) task
Verifying property shell.bower exists in config...OK
File: [no files]
Options: stdout, stderr, stdin, failOnError
Command: /Users/sebi/Development/sebgie/Ghost\ XX/node_modules/.bin/bower --allow-root install

Running "shell:ghost_ui" (shell) task

But I guess that the brackets are causing another (similar) problem. //cc: @ErisDS

Update: confirmed

Running "shell:bower" (shell) task
/bin/sh: -c: line 0: syntax error near unexpected token `Personal'
/bin/sh: -c: line 0: `/Users/sebi/Development/sebgie/Ghost\ (Personal)/node_modules/.bin/bower --allow-root install'
Warning: Command failed: /bin/sh: -c: line 0: syntax error near unexpected token `Personal'
/bin/sh: -c: line 0: `/Users/sebi/Development/sebgie/Ghost\ (Personal)/node_modules/.bin/bower --allow-root install'
 Use --force to continue.

[jamesmartinduffy]

Looks like parentheses do need to be escaped, since running this command works fine:

/Users/jamesduffy/Dropbox\ \(Personal\)/_Development/Ghost/node_modules/.bin/bower --allow-root install

But I may be in the minority here having that in my path. I have ~/dev symlinked to Dropbox (Personal)/_Development/, which is possibly why I've never run into this before.

Is there a reason for not just using a relative path instead of process.cwd()? ./node_modules/.bin/bower --allow-root install executes just fine. (Also needs to be changed for ghost_ui and coverage).

[ErisDS]

@jamesmartinduffy Hopefully #3700 will fully resolve the issue for you? (I've tested on win and mac)

[jamesmartinduffy]

Yes, that resolves it.

[ErisDS]

Wooooooooooooooooooooooooooooooooooooo 🎈