Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move team rights test data to a separate file #218

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Move team rights test data to a separate file #218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d01029c
Move team rights test data to a separate file
GoldenJaden Mar 6, 2024
cd76fc4
Wrap test context
GoldenJaden Mar 9, 2024
e8dbc8f
Rename memberRightsTestData to memberRight
GoldenJaden Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 4 additions & 96 deletions src/presentation/http/router/note.test.ts
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability decreased. I think it would have sense if the logic will be moved to the util as well. Like creating a user, adding a role, etc

Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { MemberRole } from '@domain/entities/team.js';
import { describe, test, expect, beforeEach } from 'vitest';
import type User from '@domain/entities/user.js';
import { memberRightsTestData } from '@tests/utils/team-rights';

describe('Note API', () => {
beforeEach(async () => {
Expand Down Expand Up @@ -243,38 +244,7 @@ describe('Note API', () => {
});

describe('PATCH note/:notePublicId ', () => {
test.each([
/** Returns 200 if user is team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},
])
test.each(memberRightsTestData)
TatianaFomina marked this conversation as resolved.
Show resolved Hide resolved
('Patch note by public id', async ({ role, isAuthorized, expectedStatusCode, expectedMessage }) => {
/** Only if user has a Write role, he can edit the note */
const canEdit = role === MemberRole.Write;
Expand Down Expand Up @@ -459,38 +429,7 @@ describe('Note API', () => {
});

describe('DELETE /note/:notePublicId', () => {
test.each([
/** Returns 200 if user is team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},
])
test.each(memberRightsTestData)
('Delete note by public id', async ({ role, isAuthorized, expectedStatusCode, expectedMessage }) => {
/** Create test user - creator of note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -674,38 +613,7 @@ describe('Note API', () => {

accessToken = global.auth(user.id);
});
test.each([
/** Returns 200 if user is team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},
])
test.each(memberRightsTestData)
('Unlink any parent from note by it\'s public id', async ({ role, isAuthorized, expectedStatusCode, expectedMessage }) => {
/* Create second user, who will be the creator of the note */
const creator = await global.db.insertUser();
Expand Down
187 changes: 7 additions & 180 deletions src/presentation/http/router/noteSettings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { describe, test, expect, beforeEach } from 'vitest';
import { MemberRole } from '@domain/entities/team.js';
import { memberRightsTestData } from '@tests/utils/team-rights';

describe('NoteSettings API', () => {
beforeEach(async () => {
Expand All @@ -12,38 +13,7 @@ describe('NoteSettings API', () => {
await global.db.truncateTables();
});
describe('GET /note-settings/:notePublicId ', () => {
test.each([
/** Returns 401 when the user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},

/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 when user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 403 when user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},
])
test.each(memberRightsTestData)
('Get note settings and team by public id', async ({ role, isAuthorized, expectedStatusCode, expectedMessage }) => {
/** Create test user - creator of a note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -156,38 +126,7 @@ describe('NoteSettings API', () => {
});

describe('GET /note-settings/:notePublicId/team ', () => {
test.each([
/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 401 when the user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},

/** Returns 403 when the the user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},
])
test.each(memberRightsTestData)
('Get note team by public id', async ({ role, isAuthorized, expectedStatusCode, expectedMessage }) => {
/** Create test user - creator of a note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -282,35 +221,7 @@ describe('NoteSettings API', () => {
});

describe('PATCH /note-settings/:notePublicId ', () => {
test.each([
/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
},
])
test.each(memberRightsTestData)
('Update note settings by public id', async ({ role, isAuthorized, expectedStatusCode }) => {
/** Create test user - creator of a note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -399,35 +310,7 @@ describe('NoteSettings API', () => {
});

describe('PATCH /note-settings/:notePublicId/invitation-hash ', () => {
test.each([
/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
},
])
test.each(memberRightsTestData)
('Generate invitation hash', async ({ role, isAuthorized, expectedStatusCode }) => {
/** Create test user - creator of a note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -521,35 +404,7 @@ describe('NoteSettings API', () => {
});

describe('PATCH /note-settings/:notePublicId/team', () => {
test.each([
/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
},
])
test.each(memberRightsTestData)
('Update team member role by user id and note id', async ({ role, isAuthorized, expectedStatusCode }) => {
/** Create test user - creator of a note */
const creator = await global.db.insertUser();
Expand Down Expand Up @@ -659,35 +514,7 @@ describe('NoteSettings API', () => {
});

describe('DELETE /:notePublicId/team', () => {
test.each([
/** Returns 200 if user is a team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is a team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
},
])
test.each(memberRightsTestData)
('Delete user from the team', async ( { role, isAuthorized, expectedStatusCode } ) => {
const creator = await global.db.insertUser();

Expand Down
34 changes: 34 additions & 0 deletions src/tests/utils/team-rights.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { MemberRole } from '@domain/entities/team.js';

export let memberRightsTestData: any[] = [
/** Returns 200 if user is team member with a Write role */
{
role: MemberRole.Write,
isAuthorized: true,
expectedStatusCode: 200,
},

/** Returns 403 if user is team member with a Read role */
{
role: MemberRole.Read,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 403 if user is not in the team */
{
role: null,
isAuthorized: true,
expectedStatusCode: 403,
expectedMessage: 'Permission denied',
},

/** Returns 401 if user is not authorized */
{
role: null,
isAuthorized: false,
expectedStatusCode: 401,
expectedMessage: 'You must be authenticated to access this resource',
},
];
Loading