Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move team rights test data to a separate file #218

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Move team rights test data to a separate file #218

wants to merge 3 commits into from
+86 −282

Conversation

GoldenJaden
Copy link
Contributor

Moved test data for test.each block about team rights into a separate file for more convenient usage.

neSpecc
neSpecc reviewed Mar 6, 2024
View reviewed changes
src/presentation/http/router/note.test.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability decreased. I think it would have sense if the logic will be moved to the util as well. Like creating a user, adding a role, etc

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 93.25% (🎯 80%)
⬆️ +0.48%		 6373 / 6834
🟢 Statements 93.25% (🎯 80%)
⬆️ +0.48%		 6373 / 6834
🟢 Functions 88.16% (🎯 80%)
⬆️ +2.99%		 216 / 245
🟢 Branches 89.75% (🎯 80%)
⬇️ -0.25%		 324 / 361
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/tests/utils/team-rights.ts 100% 100% 100% 100%
Generated in workflow #558

TatianaFomina
TatianaFomina reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@TatianaFomina TatianaFomina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some eslint errors
image

@GoldenJaden GoldenJaden marked this pull request as draft March 14, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc left review comments

@TatianaFomina TatianaFomina TatianaFomina approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GoldenJaden @neSpecc @TatianaFomina