Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Maximum call stack size exceeded when destructuring certain packages #5022

Closed
3 tasks done
NawarA opened this issue Oct 16, 2020 · 9 comments · Fixed by #5034
Closed
3 tasks done

Bug report: Maximum call stack size exceeded when destructuring certain packages #5022

NawarA opened this issue Oct 16, 2020 · 9 comments · Fixed by #5034
Assignees
Labels
🚨 ASAP 🎒 Bundler Refers to CodeSandbox's In-Browser Bundler

Comments

@NawarA
Copy link

NawarA commented Oct 16, 2020

🐛 bug report

Hi, a recent update to Codesandbox is now causing this error.

image

I can confirm that this error was not present a few days / last week...aka, its a recently appearing issue, likely with your latest last two releases.

Preflight Checklist

  • I have read the
    Contributing Guidelines
    for this project.
  • I agree to follow the
    Code of Conduct
    that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want
    to file, without success.

Description of the problem

We traced the bug down to this line of code (which again, worked a few days ago).

image

Meanwhile, doing simple destructuring causes infinite loops from certain packages, see below:

image

How has this issue affected you? What are you trying to accomplish?

We had to switch from Codesandbox to VSCode, becuase VSCode loads this normally...haha

Please patch your recent updates, so we can switch our team back to Codesandbox

To Reproduce

  1. Go the sandbox link below
  2. Go to the file /src/Card.js
  3. Comment out the two lines and you'll see one loads and the other causes infinite loops
  4. Recognize, this wasnt an issue a few days ago

See the screenshots above.

Thanks for your hardwork. Much love 🎸

Link to sandbox: link (optional)

https://codesandbox.io/s/epic-http-pht19?file=/src/Card.js

Your Environment

Software Name/Version
Сodesandbox 8afa3a4
Browser Chrome 86
Operating System Win 10, Ubuntu 18.04, Ubuntu 20.04
@tjxnor
Copy link

tjxnor commented Oct 19, 2020

Hi @NawarA, I'm facing the same issue.
Can you suggest how you were able to trace the error down to the offending lines? I have many different files with imports from material-ui/icons and have updated a few, but the error still persists.

Thanks!

@NawarA
Copy link
Author

NawarA commented Oct 19, 2020

I commented everything out. I then proceeded to see what was source of the issue by commenting things back in, one line at a time.

I created a demo sandbox to keep things simple and show what was causing the overflow (import aliasing).

That being said, I have a large app that I can't develop in codesandbox right now, because it'd be ludicrous to change every import alias for temporary bug on codesanbox's side. That'd produce a lot of development waste.

Our team is now using vs code, which doesn't have the issue.

@tjxnor
Copy link

tjxnor commented Oct 19, 2020

Yup, it's going to be a nightmare if the codebase is large, which I'm approaching too.
I really like the ability to code in the browser in a "no-install" setup, but guess it's time to move on.
Thanks for the approach!

@mordechaim
Copy link

mordechaim commented Oct 19, 2020

Having the same issue in https://codesandbox.io/s/naughty-hellman-7kfxt?file=/src/App.js

Removing @material-ui/icons package resolves this issue

@NawarA
Copy link
Author

NawarA commented Oct 19, 2020

Yeah, looks like destructuring is screwing up the CSB transpiler

@lbogdan
Copy link
Contributor

lbogdan commented Oct 19, 2020

Hey @NawarA & all,

Sorry for the inconvenience and the delayed response! We'll take a look at this first time tomorrow, and get it fixed ASAP!

@NawarA
Copy link
Author

NawarA commented Oct 20, 2020

Thanks @lbogdan

works now:

image

lgtm 👍

@tjxnor
Copy link

tjxnor commented Oct 21, 2020

awesome! 👍

@lbogdan
Copy link
Contributor

lbogdan commented Oct 24, 2020

@NawarA You should thank @CompuIves , he was the one that fixed it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 ASAP 🎒 Bundler Refers to CodeSandbox's In-Browser Bundler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants