Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Tabs still causes vertical scrolling. #7084

Closed
1 of 2 tasks
starpit opened this issue Oct 19, 2020 · 6 comments · Fixed by #7111
Closed
1 of 2 tasks

Switching Tabs still causes vertical scrolling. #7084

starpit opened this issue Oct 19, 2020 · 6 comments · Fixed by #7111

Comments

@starpit
Copy link

starpit commented Oct 19, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

Switching tabs can still (even with the fix for 7.22 #6974) cause vertical scrolling. See my comments here on the original issue for more detail and gif examples:

#6973 (comment)
#6973 (comment)

Is this issue related to a specific component?

Tabs

What did you expect to happen? What happened instead? What would you like to
see changed?

Switching Tabs should never cause vertical scrolling.

What browser are you working in?

Any

What version of the Carbon Design System are you using?

7.22

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Kui

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code
  • Notes
@emyarod
Copy link
Member

emyarod commented Oct 19, 2020

can you create a reduced test case in Code Sandbox for easier testing and debugging?

@starpit
Copy link
Author

starpit commented Oct 19, 2020

i'd love to help there, but i get only

InternalError too much recursion

from your sandboxes.

@emyarod
Copy link
Member

emyarod commented Oct 19, 2020

it looks like this is a current issue in Code Sandbox. we'll have to wait for them to resolve it codesandbox/codesandbox-client#5022

@emyarod
Copy link
Member

emyarod commented Oct 19, 2020

as an alternative you could also try recreating the issue in jsfiddle or codepen

@starpit
Copy link
Author

starpit commented Oct 20, 2020

@emyarod Here is a sandbox that demonstrates the vertical scrolling bug. https://codesandbox.io/s/nifty-water-3i8br

@emyarod
Copy link
Member

emyarod commented Oct 21, 2020

thanks for the example, I believe this will be resolved in #7111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants