Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing any component from elastic/eui to codesandbox in Safari throws maximum call stack size exceeded #4716

Closed
mbondyra opened this issue Apr 15, 2021 · 3 comments
Labels

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Apr 15, 2021

Steps to reproduce:

  1. Open Safari browser (my version is 14.0 (15610.1.28.1.9, 15610)
  2. Go to https://codesandbox.io/s/romantic-ardinghelli-wr9j1?file=/index.js
  3. Uncomment the line 4: import { EuiText } from "@elastic/eui";

The moment it gets uncommented, codesandbox throws an error:
Screenshot 2021-04-15 at 11 49 31

It works well with Chrome.

@mbondyra mbondyra added the bug label Apr 15, 2021
@elizabetdev
Copy link
Contributor

Confirmed. Not sure we can do anything or it should be fixed on the CodeSandbox side. What do you think @chandlerprall, @thompsongl?

That's the error in Safari:

Screenshot 2021-04-15 at 10 58 11

@thompsongl
Copy link
Contributor

Tracked the error back to EUI v28.0.0 (v27.4.1 works in Safari). EuiMarkdown* components were added in that release, which also added quite a few new dependencies and exports (npm shows an "unpacked" size increase of 18MB).
material-ui had a similar problem a while back with one of their packages. EUI is 6x larger than the package in question, though, so we may be hitting the same error on a different scale.

Also, you need to add @elastic/datemath and moment as dependencies to fulfill peerDep requirements.

@cee-chen
Copy link
Contributor

cee-chen commented Feb 6, 2023

This no longer appears to be occurring - tested on latest Safari.

@cee-chen cee-chen closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants