Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Control #16

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

MGatner
Copy link
Collaborator

@MGatner MGatner commented Jun 16, 2020

Previously .gitignore in projects was based off the file in CodeIgniter4/codeigniter4. An undesired side effect was that projects using the AppStarter failed to track composer.lock in their repos. The framework issue was corrected via codeigniter4/CodeIgniter4#3047, but this PR applies those changes to this project.

@MGatner
Copy link
Collaborator Author

MGatner commented Jun 16, 2020

Test failure is not relevant (we should probably remove or address that).

@MGatner MGatner requested a review from lonnieezell June 16, 2020 02:33
@lonnieezell lonnieezell merged commit 79a9fb4 into codeigniter4projects:develop Jun 16, 2020
@MGatner MGatner deleted the lockfile branch July 13, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants