Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cease ignoring composer.lock in deployable repos #3047

Merged
merged 1 commit into from
May 31, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 30, 2020

Description
Adds a version of .gitignore to admin/starter and admin/framework that does not include composer.lock on the ignore list. Projects should be committing their lock files, but if they start with our current repos they will receive this repo's .gitignore which (correctly) does not commit the lock file.

Checklist:

  • Securely signed commits
  • n/a Component(s) with PHPdocs
  • n/a Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit fbe8343 into codeigniter4:develop May 31, 2020
@MGatner MGatner deleted the composer-lock branch June 3, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants