chore: update rector.php #560

kenjis · 2022-12-14T07:21:48Z

add declare(strict_types=1) in rector.php
update rector version to ^0.15.1
add rector rules
remove deprecated TypedPropertyRector
refactor test code by rector
update .php-cs-fixer.dist.php

PHP Fatal error:  Uncaught _PHPStan_9a6ded56a\Nette\Schema\ValidationException: Unexpected item 'parameters › deprecationRulesInstalled'. in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php:75

Fatal error: Uncaught _PHPStan_9a6ded56a\Nette\Schema\ValidationException: Unexpected item 'parameters › deprecationRulesInstalled'. in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php:75
Stack trace:
Stack trace:
#0 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php(38): _PHPStan_9a6ded56a\Nette\Schema\Processor->throwsErrors()
#0 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php(38): _PHPStan_9a6ded56a\Nette\Schema\Processor->throwsErrors()
#1 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ParametersSchemaExtension.php(43): _PHPStan_9a6ded56a\Nette\Schema\Processor->process()
#1 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ParametersSchemaExtension.php(43): _PHPStan_9a6ded56a\Nette\Schema\Processor->process()
#2 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(182): PHPStan\DependencyInjection\ParametersSchemaExtension->loadConfiguration()
#2 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(182): PHPStan\DependencyInjection\ParametersSchemaExtension->loadConfiguration()
#3 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(158): _PHPStan_9 in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php on line 75
#3 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(158): _PHPStan_9 in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php on line 75
Error: Process completed with exit code 255.

https://github.com/codeigniter4/shield/actions/runs/3692642168/jobs/6251736949

samsonasik · 2022-12-14T07:28:00Z

You can pin to phpstan 1.9.2 or use rector dev-main that already include phpstan 1.9.3

kenjis · 2022-12-14T07:28:01Z

@samsonasik Do you know why this error happens?

PHP Fatal error:  Uncaught _PHPStan_9a6ded56a\Nette\Schema\ValidationException: Unexpected item 'parameters › deprecationRulesInstalled'. in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php:75

Fatal error: Uncaught _PHPStan_9a6ded56a\Nette\Schema\ValidationException: Unexpected item 'parameters › deprecationRulesInstalled'. in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php:75
Stack trace:
#0 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php(38): _PHPStan_9a6ded56a\Nette\Schema\Processor->throwsErrors()
#1 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ParametersSchemaExtension.php(43): _PHPStan_9a6ded56a\Nette\Schema\Processor->process()
#2 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(182): PHPStan\DependencyInjection\ParametersSchemaExtension->loadConfiguration()
#3 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(158): _PHPStan_9 in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php on line 75
Stack trace:
#0 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php(38): _PHPStan_9a6ded56a\Nette\Schema\Processor->throwsErrors()
#1 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ParametersSchemaExtension.php(43): _PHPStan_9a6ded56a\Nette\Schema\Processor->process()
#2 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(182): PHPStan\DependencyInjection\ParametersSchemaExtension->loadConfiguration()
#3 phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php(158): _PHPStan_9 in phar:///home/runner/.composer/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/schema/src/Schema/Processor.php on line 75
Error: Process completed with exit code 255.

https://github.com/codeigniter4/shield/actions/runs/3692658459/jobs/6251768963

samsonasik · 2022-12-14T07:28:36Z

You can pin to phpstan 1.9.2 or use rector dev-main that already include phpstan 1.9.3

kenjis · 2022-12-14T07:33:57Z

@samsonasik Thanks! No errors with dev-main .

kenjis · 2022-12-14T07:39:08Z

@samsonasik
I don't feel comfortable changing the GitHub workflow to dev-main, so I'll leave it as is for a while.

Will this be fixed in the next release?

samsonasik · 2022-12-14T07:41:17Z

Yes, wait for next release seems ok 👍 , the error usually happen when phpstan add new parameters config

samsonasik · 2022-12-14T16:00:58Z

@kenjis Rector 0.15.1 released, I restarted the build.

samsonasik · 2022-12-14T16:02:59Z

@kenjis the workflow seems still using rector 0.13

Run composer global require --dev rector/rector:^0.13.3
Changed current directory to /home/runner/.composer
./composer.json has been updated
Running composer update rector/rector
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 0 updates, 0 removals
  - Locking phpstan/phpstan (1.9.3)
  - Locking rector/rector (0.13.10)

shield/.github/workflows/rector.yml

Line 66 in eeebfc8

composer global require --dev rector/rector:^0.13.3

Please update to ^0.15.1

From CodeIgniter4 repository.

From devkit.

samsonasik · 2022-12-15T01:38:02Z

rector.php

+    $rectorConfig
+        ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
+            // Set to false if you use in libraries, or it does create breaking changes.
+            TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,


It false by default, no need to define in config for false value

It comes from a template file in devkit.

For devkit, that can be on purpose so user know when to enable it, I think it can be removed in here

I followed the instruction in the devkit template.

If we need to remove the default value, please update the devkit comment.
Otherwise, the code will revert again when I or someone else copy the devkit template to update in the future.

Ok, I created PR codeigniter4/devkit#61 for it.

Removed the config line.

kenjis · 2022-12-15T02:03:16Z

Why did the coverage rate drop to 69.743%?

It is 94.95% in my local environment.

Code Coverage Report:        
  2022-12-14 20:01:58        
                             
 Summary:                    
  Classes: 45.83% (22/48)    
  Methods: 79.86% (222/278)  
  Lines:   94.95% (2484/2616)

MGatner · 2022-12-15T11:33:39Z

Why did the coverage rate drop to 69.743%?

No clue!

tests/Language/AbstractTranslationTestCase.php

It is included in LevelSetList::UP_TO_PHP_74.

kenjis added 2 commits December 14, 2022 16:20

chore: add declare(strict_types=1) in rector.php

d7a621c

chore: remove deprecated TypedPropertyRector

e646b54

kenjis changed the title ~~chore: fix rectore.php~~ chore: fix rector.php Dec 14, 2022

kenjis mentioned this pull request Dec 14, 2022

Feature: Banning Users #559

Closed

kenjis added 4 commits December 15, 2022 09:12

chore: add rector.php to php-cs-fixer

61a6e6b

chore: update rector version

a0fe79d

chore: add rector rules

7813e68

From CodeIgniter4 repository.

test: remove unused property

e48867b

kenjis changed the title ~~chore: fix rector.php~~ chore: update rector.php Dec 15, 2022

kenjis added the github_actions Pull requests that update GitHub Actions code label Dec 15, 2022

kenjis added 4 commits December 15, 2022 09:23

test: run rector

6668d6c

chore: add rector rules

0561a63

From devkit.

chore: skip AnnotationWithValueToAttributeRector

6dfb295

test: run rector

a319eb0

samsonasik reviewed Dec 15, 2022

View reviewed changes

MGatner reviewed Dec 15, 2022

View reviewed changes

tests/Language/AbstractTranslationTestCase.php Show resolved Hide resolved

samsonasik mentioned this pull request Dec 16, 2022

[Rector] Update comment usage for TypedPropertyFromAssignsRector codeigniter4/devkit#61

Merged

chore: remove TypedPropertyFromAssignsRector config

23c2527

It is included in LevelSetList::UP_TO_PHP_74.

MGatner approved these changes Dec 16, 2022

View reviewed changes

kenjis requested a review from samsonasik December 17, 2022 02:22

samsonasik approved these changes Dec 17, 2022

View reviewed changes

kenjis merged commit 22ccaf4 into codeigniter4:develop Dec 17, 2022

kenjis deleted the fix-rector-config branch December 17, 2022 02:43

datamweb mentioned this pull request Feb 14, 2023

chore: add Language to coverage exclude #636

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update rector.php #560

chore: update rector.php #560

kenjis commented Dec 14, 2022 •

edited

Loading

samsonasik commented Dec 14, 2022

kenjis commented Dec 14, 2022

samsonasik commented Dec 14, 2022

kenjis commented Dec 14, 2022

kenjis commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik Dec 15, 2022

kenjis Dec 15, 2022

samsonasik Dec 15, 2022

kenjis Dec 16, 2022

samsonasik Dec 16, 2022

kenjis Dec 16, 2022

kenjis commented Dec 15, 2022

MGatner commented Dec 15, 2022

chore: update rector.php #560

chore: update rector.php #560

Conversation

kenjis commented Dec 14, 2022 • edited Loading

samsonasik commented Dec 14, 2022

kenjis commented Dec 14, 2022

samsonasik commented Dec 14, 2022

kenjis commented Dec 14, 2022

kenjis commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik commented Dec 14, 2022

samsonasik Dec 15, 2022

Choose a reason for hiding this comment

kenjis Dec 15, 2022

Choose a reason for hiding this comment

samsonasik Dec 15, 2022

Choose a reason for hiding this comment

kenjis Dec 16, 2022

Choose a reason for hiding this comment

samsonasik Dec 16, 2022

Choose a reason for hiding this comment

kenjis Dec 16, 2022

Choose a reason for hiding this comment

kenjis commented Dec 15, 2022

MGatner commented Dec 15, 2022

kenjis commented Dec 14, 2022 •

edited

Loading