[Rector] Update comment usage for TypedPropertyFromAssignsRector #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
approved these changes
Dec 16, 2022
kenjis
reviewed
Dec 19, 2022
| /** | ||
| * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74 | ||
| * Set to true for projects that allow BC break | ||
| */ | ||
| TypedPropertyFromAssignsRector::INLINE_PUBLIC => true, |
There was a problem hiding this comment.
I have applied this setting to an App, but many files that extend framework classes were broken because not all properties are typed.
Realistically, it seems to be difficult to use this setting with true.
There was a problem hiding this comment.
Yes, that's true is usefull when need to be applied for whole project.
Probably next improvement to verify vendor/ location like in ParentClassMethodTypeOverrideGuard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on codeigniter4/shield#560 (comment), I updated comment for TypedPropertyFromAssignsRector