Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add/fix PHPDoc types in MockCache #8612

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 8, 2024

Description
PHPStan update now causes an error.
PHPDoc types have been fixed along with it.

 ------ ---------------------------------------------------------------------------------------------------- 
  Line   system/Test/Mock/MockCache.php                                                                      
 ------ ---------------------------------------------------------------------------------------------------- 
         Ignored error pattern #^Cannot unset offset string on array<int, int>\|null\.$# in path             
         /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Test/Mock/MockCache.php was not matched  
         in reported errors.                                                                                 
 ------ ---------------------------------------------------------------------------------------------------- 

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Mar 9, 2024
5 tasks
@kenjis kenjis merged commit 9342e38 into codeigniter4:develop Mar 10, 2024
62 checks passed
@kenjis kenjis deleted the fix-MockCache-phpstan-errors branch March 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants