-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DebugBar] scroll to top #8595
Conversation
@acpadhi Updated all button |
Thanks, but Line Number : 31 - role="button" missing, so when debugbar is closed, cursor change not working when hover on toggle button.
There is another issue in the debugbar, when the View button is clicked, it does not highlight as selected button. Rest all buttons in the toolbar get highligted when they are toggled. Should this go as a separate issue or can be handled in this PR itself ? |
What do you mean? What is the toggle button? |
@acpadhi Can you record? |
admin/css/debug-toolbar/toolbar.scss
Outdated
@@ -36,6 +39,9 @@ | |||
clear: both; | |||
text-align: center; | |||
|
|||
// Cursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this comment, in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@kenjis |
@ddevsr In debugbar when someone clicks on the Views button to show the views higlighted in the page, the button in the toolbar should also have a darker background to highlight that the views button has been toggled to an ON state, just like how the other buttons in the debugbar behave. If this is confusing, please let me know and I will write back again to explain. |
2024-03-05.14.21.59.mov |
"Views" tab shows nothing, so isn't the behavior intentional? |
In my Opinion, it is kind of not directly imminent that that the view button is clicked, I understant that there is border highlithing on page view areas, but when working on a large pages, visually it can be distracting to see gaps in design and wondering if some css is causing it. A dark background in the button will immediately convey "Oh my debugbar view button is toggled, so I see the gaps" . This is not a pressing thing, just a suggestion to keep consistency, since afterall it is a toggle, irrespective of whenther showing additional content or not. |
@acpadhi Ah, I got what you say. You say it is better that when the "Views" is on, the "Views" is darker. |
Yes, that way this Views button will be conistent with other buttons on the visual aspect, and also make it exlicit that it is in ON state. |
@acpadhi I agree with your opinion. But the current behavior is not a bug. So changing it will be an enhancement. This PR seems good to me. |
@ddevsr It is an enhancement, not a bug fix. Please send a new PR to |
99bdf23
to
0fc5485
Compare
The following error will be fixed by #8612.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fixed #8594
Checklist: