test: ensure cleanup of sqlite3 db files after test #8393

paulbalandan · 2023-12-30T18:20:27Z

Description
Currently, writable/ has two leftover DB files from sqlite3: database.db and runner.sqlite. This PR cleans them.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

michalsn · 2023-12-30T20:59:46Z

Oh... seems like SQLite3 tests are failing now.

kenjis

PHPUnit 9.6.15 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.33
Configuration: /home/runner/work/CodeIgniter4/CodeIgniter4/phpunit.xml.dist

..S............................................................  63 / 667 (  9%)
...............S.S...S...........S............................. 126 / 667 ( 18%)
............................................................... 189 / 667 ( 28%)
......SSSSSSSSSSSSSSSSS.........................EEEEEEEEEEEEEEE 252 / 667 ( 37%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 315 / 667 ( 47%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 378 / 667 ( 56%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 441 / 667 ( 66%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE... 504 / 667 ( 75%)
.....EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 567 / 667 ( 85%)
EEEEEEEEEEEEEEEEEEEEEEEEEEE.................................... 630 / 667 ( 94%)
.............EEEEEEEEEEEEEEEEEEEEEEEE                           667 / 667 (100%)

Time: 00:10.854, Memory: 94.00 MB

There were 373 errors:

1) CodeIgniter\Database\Live\SelectTest::testSelectAllByDefault
CodeIgniter\Database\Exceptions\DatabaseException: SQLite3::exec(): attempt to write a readonly database

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:647
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Forge.php:637
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/_support/Database/Migrations/20160428212500_Create_test_tables.php:165
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:865
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:288
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:134
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:103
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:55
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:249
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:106

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: SQLite3::exec(): attempt to write a readonly database

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/SQLite3/Connection.php:151
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:693
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:607
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Forge.php:637
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/_support/Database/Migrations/20160428212500_Create_test_tables.php:165
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:865
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:288
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:134
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:103
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:55
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:249
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:106

Caused by
ErrorException: SQLite3::exec(): attempt to write a readonly database

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/SQLite3/Connection.php:145
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:693
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:607
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Forge.php:637
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/_support/Database/Migrations/20160428212500_Create_test_tables.php:165
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:865
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MigrationRunner.php:288
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:134
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:103
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:55
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:249
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:106

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7365649229/job/20047227573?pr=8393

kenjis · 2023-12-30T22:30:12Z

To begin with, DatabaseLive tests fail in develop. Why?

$ vendor/bin/phpunit --group DatabaseLive
PHPUnit 9.6.15 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.13
Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml

..S...........................................................................S.S...S...........S.......... 107 / 667 ( 16%)
........................................................................................SSSSSSSSSSSSSSSSS.. 214 / 667 ( 32%)
........................................EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 321 / 667 ( 48%)
EEEEEEEEEEEEEEEEEEEE...............................EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 428 / 667 ( 64%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE........EEEEEEEEEEEEEEEEEEEEEEEEEE 535 / 667 ( 80%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.....EEEEE.E.................................... 642 / 667 ( 96%)
.EEEEEEEEEEEEEEEEEEEEEEEE                                                                                   667 / 667 (100%)

Time: 00:11.947, Memory: 102.00 MB

There were 331 errors:

1) CodeIgniter\Database\Live\TransactionDBDebugFalseTest::testTransStartTransException
CodeIgniter\Database\Exceptions\DatabaseException: SQLite3::exec(): no such table: db_user

/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/BaseConnection.php:647
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/BaseBuilder.php:2712
/Users/kenji/work/codeigniter/official/CodeIgniter4/tests/_support/Database/Seeds/CITestSeeder.php:180
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/Seeder.php:145
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Test/DatabaseTestTrait.php:205
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Test/DatabaseTestTrait.php:193
...

paulbalandan · 2024-01-02T14:34:25Z

To begin with, DatabaseLive tests fail in develop. Why?

I thought this was on my machine only.

The failing test is saying DELETE FROM db_user fails because db_user does not exist, but it seems to be existing.

MGatner

Welp, I approved before I saw test results and the discussion 🤦‍♂️ Code looks good though, haha!

github-actions · 2024-01-20T22:13:32Z

👋 Hi, @paulbalandan!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-01-24T01:55:03Z

@paulbalandan I found the cause. #8447
When we use :memory:, a new connection will create a new database.
So if we change $this->db, it will connect to a different database.

paulbalandan · 2024-01-29T16:26:44Z

I am really confused why changes to SQLite break tests on linux but not on macos.

kenjis · 2024-01-30T05:10:44Z

tests/system/Database/Live/SQLite3/GetFieldDataTest.php

+
+        if (is_file(WRITEPATH . 'database.db')) {
+            unlink(WRITEPATH . 'database.db');
+        }


You should not remove the database file in use.
It causes "SQLite3::exec(): attempt to write a readonly database"
because the file is gone, but the connection remains.

Try:
Set database.tests.database = database.db and

$ vendor/bin/phpunit tests/system/Database/

kenjis · 2024-01-30T05:15:20Z

I think we don't need to remove database.db. It is the main database for SQLite3 testing.
We don't remove other driver's databases in testing.

paulbalandan · 2024-01-30T12:58:43Z

Yes, or it could be that there are lingering shared DB connections used by the next test instead of creating a new one.

Based on the stack trace, the error comes from setUpDatabase.

kenjis · 2024-01-31T00:31:34Z

We use the shared DB connection during all tests by default.
Database::connect($this->DBGroup) is a static method and returns the shared instance.

CodeIgniter4/system/Test/DatabaseTestTrait.php

Lines 72 to 74 in 65c6692

    
           if ($this->db === null) { 
        
               $this->db = Database::connect($this->DBGroup); 
        
               $this->db->initialize();

I think reconnecting for each test class would slow down the tests.

github-actions · 2024-02-01T00:14:35Z

👋 Hi, @paulbalandan!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-03-11T00:03:05Z

runner.sqlite was removed after running tests tests/system/Database/.

paulbalandan added the testing Pull requests that changes tests only label Dec 30, 2023

lonnieezell approved these changes Dec 30, 2023

View reviewed changes

michalsn approved these changes Dec 30, 2023

View reviewed changes

kenjis requested changes Dec 30, 2023

View reviewed changes

MGatner approved these changes Jan 3, 2024

View reviewed changes

MGatner requested changes Jan 3, 2024

View reviewed changes

github-actions bot added the stale Pull requests with conflicts label Jan 20, 2024

paulbalandan force-pushed the leftover-db-files branch from 873c932 to 6636137 Compare January 26, 2024 13:21

paulbalandan removed the stale Pull requests with conflicts label Jan 26, 2024

paulbalandan force-pushed the leftover-db-files branch 5 times, most recently from 30bfaa3 to 84134b8 Compare January 29, 2024 16:11

kenjis reviewed Jan 30, 2024

View reviewed changes

github-actions bot added the stale Pull requests with conflicts label Feb 1, 2024

test: ensure cleanup of sqlite3 db files after test

c85cd6d

paulbalandan force-pushed the leftover-db-files branch from 84134b8 to c85cd6d Compare March 10, 2024 15:00

kenjis removed the stale Pull requests with conflicts label Mar 10, 2024

kenjis approved these changes Mar 11, 2024

View reviewed changes

paulbalandan requested a review from MGatner March 11, 2024 12:36

kenjis merged commit 985ac9f into codeigniter4:develop Mar 18, 2024
59 checks passed

paulbalandan deleted the leftover-db-files branch March 18, 2024 02:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: ensure cleanup of sqlite3 db files after test #8393

test: ensure cleanup of sqlite3 db files after test #8393

paulbalandan commented Dec 30, 2023 •

edited by kenjis

Loading

michalsn commented Dec 30, 2023

kenjis left a comment

kenjis commented Dec 30, 2023

paulbalandan commented Jan 2, 2024

MGatner left a comment

github-actions bot commented Jan 20, 2024

kenjis commented Jan 24, 2024

paulbalandan commented Jan 29, 2024

kenjis Jan 30, 2024 •

edited

Loading

kenjis commented Jan 30, 2024

paulbalandan commented Jan 30, 2024

kenjis commented Jan 31, 2024

github-actions bot commented Feb 1, 2024

kenjis commented Mar 11, 2024

test: ensure cleanup of sqlite3 db files after test #8393

test: ensure cleanup of sqlite3 db files after test #8393

Conversation

paulbalandan commented Dec 30, 2023 • edited by kenjis Loading

michalsn commented Dec 30, 2023

kenjis left a comment

Choose a reason for hiding this comment

kenjis commented Dec 30, 2023

paulbalandan commented Jan 2, 2024

MGatner left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2024

kenjis commented Jan 24, 2024

paulbalandan commented Jan 29, 2024

kenjis Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

kenjis commented Jan 30, 2024

paulbalandan commented Jan 30, 2024

kenjis commented Jan 31, 2024

github-actions bot commented Feb 1, 2024

kenjis commented Mar 11, 2024

paulbalandan commented Dec 30, 2023 •

edited by kenjis

Loading

kenjis Jan 30, 2024 •

edited

Loading