Merge pull request #8393 from paulbalandan/leftover-db-files

test: ensure cleanup of sqlite3 db files after test
codeigniter4 · Mar 18, 2024 · 985ac9f · 985ac9f
2 parents c190334 + c85cd6d
commit 985ac9f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/tests/system/Database/Live/SQLite3/GetFieldDataTest.php b/tests/system/Database/Live/SQLite3/GetFieldDataTest.php
@@ -32,7 +32,7 @@ protected function createForge(): void
             'database' => 'database.db',
             'DBDebug'  => true,
         ];
-        $this->db    = db_connect($config);
+        $this->db    = db_connect($config, false);
         $this->forge = Database::forge($config);
     }
 

diff --git a/tests/system/Database/Live/SQLite3/GetIndexDataTest.php b/tests/system/Database/Live/SQLite3/GetIndexDataTest.php
@@ -45,7 +45,7 @@ protected function setUp(): void
             'database' => 'database.db',
             'DBDebug'  => true,
         ];
-        $this->db    = db_connect($config);
+        $this->db    = db_connect($config, false);
         $this->forge = Database::forge($config);
     }
 

diff --git a/tests/system/Database/Migrations/MigrationRunnerTest.php b/tests/system/Database/Migrations/MigrationRunnerTest.php
@@ -470,6 +470,10 @@ public function testMigrationUsesSameConnectionAsMigrationRunner(): void
         $this->assertCount(2, $tables);
         $this->assertSame('migrations', $tables[0]);
         $this->assertSame('foo', $tables[1]);
+
+        if (is_file($config['database'])) {
+            unlink($config['database']);
+        }
     }
 
     protected function resetTables($db = null): void