Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DebugBar] timeline annoying line on Debug #8063

Closed
wants to merge 1 commit into from

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Oct 20, 2023

Description
Before:
image

After:
image

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 20, 2023
@ddevsr
Copy link
Collaborator Author

ddevsr commented Oct 20, 2023

Another bug after switch to light and back again dark will change timeline-parent-open to dark

image

Expected after switch light
image

@michalsn
Copy link
Member

For now, I'm a bit confused...
I can't recreate the error from the first comment and the error from the second one is not fixed.

@kenjis
Copy link
Member

kenjis commented Oct 21, 2023

I also cannot reproduce the Before: annoying line.
Screenshot 2023-10-21 20 22 02

@kenjis
Copy link
Member

kenjis commented Oct 21, 2023

v4.4.1 seems to be good.
Screenshot 2023-10-21 20 40 20

@MGatner
Copy link
Member

MGatner commented Oct 22, 2023

@ddevsr What browser/OS/framework version?

@ddevsr
Copy link
Collaborator Author

ddevsr commented Oct 26, 2023

Windows 10 with chrome latest 118

@kenjis
Copy link
Member

kenjis commented Oct 26, 2023

macOS/Chrome 118.0.5993.117
Screenshot 2023-10-26 21 05 10

@michalsn
Copy link
Member

@ddevsr Does your screenshot come from the default welcome page, or is it an in-app page, with extra CSS styles?

@ddevsr
Copy link
Collaborator Author

ddevsr commented Oct 27, 2023

Sorry, i think conflict with my adminlte or custom css. I will close this

@ddevsr ddevsr closed this Oct 27, 2023
@ddevsr ddevsr deleted the fix-line branch October 27, 2023 02:31
@kenjis
Copy link
Member

kenjis commented Oct 27, 2023

Okay, but we still have the issue #8064 that we cannot see "Controller" in the dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants