Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [DebugBar] after switch light and back to dark #8064

Closed
ddevsr opened this issue Oct 20, 2023 · 4 comments · Fixed by #8125
Closed

Bug: [DebugBar] after switch light and back to dark #8064

ddevsr opened this issue Oct 20, 2023 · 4 comments · Fixed by #8125
Labels
bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request

Comments

@ddevsr
Copy link
Collaborator

ddevsr commented Oct 20, 2023

PHP Version

8.2

CodeIgniter4 Version

4.4.2

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

Windows

Which server did you use?

apache

Database

x

What happened?

#8063 (comment)

Another bug after switch to light and back again dark will change timeline-parent-open to dark

image

Steps to Reproduce

Open your debug bar in dark

Expected Output

image

Anything else?

No response

@ddevsr ddevsr added bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request labels Oct 20, 2023
@kenjis
Copy link
Member

kenjis commented Oct 21, 2023

Reverting #7907 seems to solve the issue.
But I approved the PR, so it was okay at that time...

--- a/admin/css/debug-toolbar/_theme-dark.scss
+++ b/admin/css/debug-toolbar/_theme-dark.scss
@@ -150,10 +150,6 @@
         .timer {
             background-color: $g-orange;
         }
-
-        .timeline-parent-open td {
-            color: $t-dark;
-        }
     }
 }

Screenshot 2023-10-21 20 52 03

@kenjis
Copy link
Member

kenjis commented Oct 21, 2023

Reverting #7907 and I used Edge, I was able to reproduce the issue.
Screenshot 2023-10-21 21 09 04
But after switching to light mode and dark mode again, the issue was disappeared.
I cannot reproduce it now.

@sfadschm
Copy link
Contributor

I feel switching the light/dark mode should not affect styles, but rather toggle them, or should it?
Is there some JS running on the mode change which alters the DOM elements ? Otherwise it does not make sense to me that the error only occurs on switching back and forth.

@kenjis kenjis changed the title Bug: DebugBar after switch light and back to dark Bug: [DebugBar] after switch light and back to dark Oct 29, 2023
@kenjis
Copy link
Member

kenjis commented Oct 30, 2023

I sent PR #8125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants