Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4.2 Ready code #8062

Merged
merged 303 commits into from
Oct 19, 2023
Merged

4.4.2 Ready code #8062

merged 303 commits into from
Oct 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 19, 2023

No description provided.

kenjis and others added 30 commits September 8, 2023 17:35
It caused an error.

Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209

Error: ] Could not process
         "/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
         onse.php" file, due to:
         "System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
         Return value must be of type int, null returned"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
         209

Error: Process completed with exit code 1.
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
…wedConstructs

chore: add phpstan-strict-rules disallowedConstructs
refactor: remove unneeded arguments to session
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
GH: auto label conflict PR
chore: fix move labeler conflict PR
samsonasik and others added 28 commits October 16, 2023 11:28
[Rector] Apply BooleanInIfConditionRuleFixerRector
fix: `spark routes` may show incorrect route names
Sort by full path.
…le_upload

docs: fix anchor text in installation/upgrade_file_upload.rst
docs: add note for routes after calling resetServices()
There was 1 failure:

1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
…sConnectionTimings

test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
fix: file sort order in Files DebugBar
@kenjis kenjis mentioned this pull request Oct 19, 2023
5 tasks
@kenjis kenjis merged commit cf43310 into master Oct 19, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.