Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rector.php #7904

Merged
merged 6 commits into from
Sep 8, 2023
Merged

chore: update rector.php #7904

merged 6 commits into from
Sep 8, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 6, 2023

Description

  • replace deprecated sets

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft September 6, 2023 09:24
kenjis
kenjis commented Sep 6, 2023
View reviewed changes
rector.php Show resolved Hide resolved
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Sep 7, 2023
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
9ce4ec5 
…t::PHPUNIT_100

It does not work for us.
See codeigniter4#7904 (comment)
@kenjis kenjis marked this pull request as ready for review September 7, 2023 06:55
samsonasik
samsonasik reviewed Sep 7, 2023
View reviewed changes
rector.php Outdated Show resolved Hide resolved
@samsonasik samsonasik mentioned this pull request Sep 7, 2023
Closed
@kenjis
docs: add "see test" annotations
6329255
@kenjis
chore: replace deprecated sets
ef15d93
@kenjis
chore: use PPHPUnitLevelSetList::UP_TO_PHPUNIT_100 instead of PHPUnit…
d669efa 
…SetList::PHPUNIT_80
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b 
It caused an error.

Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209

Error: ] Could not process
         "/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
         onse.php" file, due to:
         "System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
         Return value must be of type int, null returned"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
         209

Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d 
…t::PHPUNIT_100

It does not work for us.
See codeigniter4#7904 (comment)
@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2023

Rebased to resolve conflict.

@samsonasik samsonasik merged commit 64819ee into codeigniter4:develop Sep 8, 2023
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the update-rector.php branch September 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik