fix redis + where + pageError #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error thrown is always：pageNotFound and fixed it
The following is wrong: Argument 1 passed to CodeIgniter\Cache\Handlers\RedisHandler::__construct() must be of the type array, object given, called in ... fixed it
Ci3 can be, I have been accustomed to write, because you can write functions, $where can be as a parameter by value, if there is no $where you can pass null, now to determine $where exists, is not very convenient
CI3 like this
public function getSort($db, $where = null, $order = 'id desc') {
return $this->db->select('sort')->order_by($order)->where($where)->get()->result();
}
but now, CI4 like this
public function getSort($db, $where = null, $order = 'id desc') {
$this->db->table($db)->select('sort')->orderBy($order);
if ($where !== null) {
$this->db->where($where);
}
return $this->db->get()->getResult();
}
This way, it doesn't get smooth！
So fixed it
lonnieezell
requested changes
Oct 24, 2017
| @@ -574,8 +574,13 @@ public function join($table, $cond, $type = '', $escape = null) | |||
| * | |||
| * @return BaseBuilder | |||
| */ | |||
| public function where($key, $value = null, $escape = null) | |||
| public function where($key = null, $value = null, $escape = null) | |||
There was a problem hiding this comment.
Sorry. Can't accept this one. $key is always required and it should fail loudly when the developer forgets to add it.
This was referenced Oct 24, 2017
Closed
Closed
Closed
|
I wasn't thinking on your previous mention about where's and null. I don't think it's right to allow that in this case as it could be a bit dangerous and hard to track down during debugging. Sorry about that. |
|
@jinmarcus Are you going to be able to revise this PR by removing the one fix so I can merge the others? |
|
Being picky, but we expect commits to be GPG-signed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix redis + where + pageError