Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about Error Handling #778

Closed
jinmarcus opened this issue Oct 16, 2017 · 7 comments · Fixed by #1168
Closed

about Error Handling #778

jinmarcus opened this issue Oct 16, 2017 · 7 comments · Fixed by #1168

Comments

@jinmarcus
Copy link

jinmarcus commented Oct 16, 2017

throw new \CodeIgniter\PageNotFoundException('Controller is empty.');

The error thrown is always:pageNotFound

CodeIgniter.php 791 lines:

throw new PageNotFoundException(lang('HTTP.pageNotFound'));

Should it be this:

throw new PageNotFoundException(empty($e->getMessage()) ? lang('HTTP.pageNotFound') : $e->getMessage());
@jinmarcus
Copy link
Author

Can't the problem be solved?

@lonnieezell
Copy link
Member

Yes, that looks like it would fix the issue. Care to submit a PR?

@jinmarcus
Copy link
Author

I've submitted a PR.

@lonnieezell
Copy link
Member

@jinmarcus I don't see any pull requests for this listed.

@jinmarcus
Copy link
Author

#792

@jinmarcus
Copy link
Author

jinmarcus commented Feb 10, 2018

@lonnieezell Does this PR have no fixed?#792

@lonnieezell
Copy link
Member

Changes were requested in that pull request that were never implemented. I can’t accept the PR until it’s fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants