Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to full_path index of uploaded files #7541

Merged
merged 13 commits into from
Jun 9, 2023

Conversation

timbatt
Copy link
Contributor

@timbatt timbatt commented Jun 5, 2023

Description
Supersedes #7538

Added UploadedFile::getClientPath() method.
This returns the full_path index of uploaded files (when uploaded via directory).
This feature is only available in PHP 8.1+. If the method is called below that version then null is returned.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@timbatt
Copy link
Contributor Author

timbatt commented Jun 5, 2023

Ok, let's try again. I fixed all the linting errors, updated the style of my new code, and enabled commit signing, so it should pass the workflow checks.

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.4 labels Jun 5, 2023
@timbatt
Copy link
Contributor Author

timbatt commented Jun 6, 2023

Hmm, ok. I guess there are still errors. I'll figure those out.

@kenjis
Copy link
Member

kenjis commented Jun 6, 2023

We still support PHP 7.4. So code must work on PHP 7.4.

@kenjis
Copy link
Member

kenjis commented Jun 6, 2023

Add a short description in the changelog to let devs know this enhancement.
https://github.com/codeigniter4/CodeIgniter4/blob/4.4/user_guide_src/source/changelogs/v4.4.0.rst#libraries

@timbatt
Copy link
Contributor Author

timbatt commented Jun 6, 2023

The 1 failed check is this:
image
It doesn't look like any of the changes I made would cause it, though I can look into fixing this one too.

@kenjis
Copy link
Member

kenjis commented Jun 6, 2023

It is because of PHPStan update.
I sent #7542 to develop already.

@timbatt
Copy link
Contributor Author

timbatt commented Jun 6, 2023

Ok, great. Is there anything else you need me to do on my end before merging?

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@kenjis kenjis requested a review from samsonasik June 8, 2023 23:29
@kenjis kenjis merged commit 5ea0f6f into codeigniter4:4.4 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants