Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added UploadedFile::getClientPath() #7538

Closed
wants to merge 1 commit into from
Closed

added UploadedFile::getClientPath() #7538

wants to merge 1 commit into from

Conversation

timbatt
Copy link
Contributor

@timbatt timbatt commented Jun 3, 2023

Enables access to the full_path index (added in PHP 8.1) for files in directory uploads.

Description
Add the file's full_path value to UploadedFile, accessible via UploadedFile::getClientPath().
If PHP version is below 8.1 then UploadedFile::getClientPath() returns null.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Enables access to the `full_path` index for uploaded files (on directory
upload)
@timbatt
Copy link
Contributor Author

timbatt commented Jun 3, 2023

This is my first PR ever, so I am new to the process.
Please feel free to point me in the right direction if I missed anything in the PR process.

@iRedds
Copy link
Collaborator

iRedds commented Jun 4, 2023

@kenjis kenjis added wrong branch PRs sent to wrong branch GPG-Signing needed Pull requests that need GPG-Signing docs needed Pull requests needing documentation write-ups and/or revisions. enhancement PRs that improve existing functionalities labels Jun 4, 2023
@kenjis
Copy link
Member

kenjis commented Jun 4, 2023

Thank you for sending PR.

  1. You need to sign your commits. https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
  2. This PR is an enhancement. So you must send it to 4.4 branch. https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

And please fix all errors in GitHub Action checks.
If you have any questions, feel free to ask.

@timbatt
Copy link
Contributor Author

timbatt commented Jun 5, 2023

Ok, will do. Thanks!

@timbatt timbatt closed this by deleting the head repository Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needed Pull requests needing documentation write-ups and/or revisions. enhancement PRs that improve existing functionalities GPG-Signing needed Pull requests that need GPG-Signing wrong branch PRs sent to wrong branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants