Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelogs 4.3.0 #6971

Merged
merged 4 commits into from
Dec 16, 2022
Merged

docs: update changelogs 4.3.0 #6971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bed74d
docs: add link to config file changes
kenjis Dec 12, 2022
23b9909
docs: add missing app/Config/Logger.php change
kenjis Dec 12, 2022
2066a09
docs: add Highlights
kenjis Dec 12, 2022
9511b4b
docs: improve Highlights item
kenjis Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion user_guide_src/source/changelogs/v4.3.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,18 @@ Release Date: Unreleased
Highlights
**********

- TBD
- Query Builder supports **upsert()**, **upsertBatch()**, **deleteBatch()** and
now ***batch()** methods can set data from a query
(*contributed by* `sclubricants <https://github.com/sclubricants>`_).
See `Query Builder`_.
- Database Forge supports to **add indexes in the existing tables** and
**name indexes** (*contributed by* `sclubricants <https://github.com/sclubricants>`_).
See `Forge`_.
- To make the default configuration more secure, the default Validation Rules
have been changed to **Strict Rules**.
- When a database error occurs, the conditions that an exception is thrown and
the exception classes that can be thrown have been changed.
See :ref:`exceptions-when-database-errors-occur`.

BREAKING
********
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Model: Model::update() method now raises a DatabaseException if it generates an SQL
    statement     without a WHERE clause; Model does not support operations that update all records.

Line 99

Should be generates a SQL statement

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 181 and 184 seem to have an unneeded empty line.

Line 183

  • In addition to the added $asQuery parameter above the following methods also now return an array.

Should be:

  • In addition to the added $asQuery parameter above the following methods also now returns an array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems both a SQL and an SQL can be used.
https://english.stackexchange.com/questions/5265/an-sql-server-database-schema-or-a-sql-server-database-schema

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following methods also now return an array

It seems return is correct. Why returns?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use an SQL when referring to the language because it is an acronym of Structured Query Language and should be pronounced as S-Q-L. If referring to the driver Microsoft has, then it is a SQL because it's pronounced as sequel.

return is correct because it refers to the following methods.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity for you guys is it:

A SQLite database

Or

An SQLite database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that English native speakers pronounce "sequel".

In my country, SQL is a foreign word, and it is pronounced like "ess-queue-el" 100%.
It may surprise you but Microsoft SQL Server is pronounced like "ess-queue-el server".

SQLite is like "ess-queue-light".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I move between both of them so I'm fine with either solution. I don't think there's a right or wrong here.

Copy link
Member

@sclubricants sclubricants Dec 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official way to pronounce “MySQL” is “My Ess Que Ell” (not “my sequel”), but we do not mind if you pronounce it as “my sequel” or in some other localized way.

https://dev.mysql.com/doc/refman/8.0/en/what-is-mysql.html#idm139761506951328

I guess I've been saying it wrong all these years.

https://sqlite.org/forum/info/42c5eb449056aa7e#:~:text=server.%22%20SQLite%20is%20typically%20pronounced,conventional%20way%20to%20say%20it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLite creator says pronounce it however you like.

https://english.stackexchange.com/questions/431329/what-is-the-correct-pronunciation-of-sqlite

Expand Down Expand Up @@ -323,6 +334,7 @@ Changes

- Config
- All atomic type properties in ``Config`` classes have been typed.
- See :ref:`Upgrading <upgrade_430_config>` for information on changing the default values.
- Changed the processing of Spark commands:
- The ``CodeIgniter\CodeIgniter`` no longer handles Spark commands.
- The ``CodeIgniter::isSparked()`` method has been removed.
Expand Down
5 changes: 5 additions & 0 deletions user_guide_src/source/installation/upgrade_430.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ Content Changes
The following files received significant changes (including deprecations or visual adjustments)
and it is recommended that you merge the updated versions with your application:

.. _upgrade_430_config:

Config
------

Expand All @@ -258,6 +260,9 @@ Config
- app/Config/Exceptions.php
- Two additional public properties were added: ``$logDeprecations`` and ``$deprecationLogLevel``.
See See :ref:`logging_deprecation_warnings` for details.
- app/Config/Logger.php
- The property ``$threshold`` has been changed to ``9`` in other than ``production``
environment.
- app/Config/Modules.php
- The new property ``$composerPackages`` is added to limit Composer package Auto-Discovery for better
performance.
Expand Down