Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelogs 4.3.0 #6971

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 12, 2022

Description

  • add highlights
  • add missing items

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added documentation Pull requests for documentation only 4.3 labels Dec 12, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either on the database errors.

Copy link
Member

@sclubricants sclubricants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • BaseConnection::escape() now excludes the RawSql data type. This allows passing SQL strings into data.

This is potentially a really helpful feature, not sure if it deserves mention in highlights.

See `Forge`_.
- To make the default configuration more secure, the default Validation Rules
have been changed to **Strict Rules**.
- The behavior when a database error occurs has been changed. See :ref:`exceptions-when-database-errors-occur`.

BREAKING
********
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Model: Model::update() method now raises a DatabaseException if it generates an SQL
    statement
    without a WHERE clause; Model does not support operations that update all records.

Line 99

Should be generates a SQL statement

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 181 and 184 seem to have an unneeded empty line.

Line 183

  • In addition to the added $asQuery parameter above the following methods also now return an array.

Should be:

  • In addition to the added $asQuery parameter above the following methods also now returns an array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following methods also now return an array

It seems return is correct. Why returns?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use an SQL when referring to the language because it is an acronym of Structured Query Language and should be pronounced as S-Q-L. If referring to the driver Microsoft has, then it is a SQL because it's pronounced as sequel.

return is correct because it refers to the following methods.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity for you guys is it:

A SQLite database

Or

An SQLite database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that English native speakers pronounce "sequel".

In my country, SQL is a foreign word, and it is pronounced like "ess-queue-el" 100%.
It may surprise you but Microsoft SQL Server is pronounced like "ess-queue-el server".

SQLite is like "ess-queue-light".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I move between both of them so I'm fine with either solution. I don't think there's a right or wrong here.

Copy link
Member

@sclubricants sclubricants Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official way to pronounce “MySQL” is “My Ess Que Ell” (not “my sequel”), but we do not mind if you pronounce it as “my sequel” or in some other localized way.

https://dev.mysql.com/doc/refman/8.0/en/what-is-mysql.html#idm139761506951328

I guess I've been saying it wrong all these years.

https://sqlite.org/forum/info/42c5eb449056aa7e#:~:text=server.%22%20SQLite%20is%20typically%20pronounced,conventional%20way%20to%20say%20it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenjis
Copy link
Member Author

kenjis commented Dec 14, 2022

  • BaseConnection::escape() now excludes the RawSql data type. This allows passing SQL strings into data.

This is potentially a really helpful feature, not sure if it deserves mention in highlights.

Just reading that description, I can't see where it can be used.
So I don't think it will be understood very well if we describe it in the highlights.

@kenjis kenjis merged commit f51e8ef into codeigniter4:4.3 Dec 16, 2022
@kenjis kenjis deleted the fix-docs-changelogs-430 branch December 16, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.3 documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants