Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace time() with Time in BaseModel #6825

Merged
merged 2 commits into from
Nov 7, 2022
Merged

refactor: replace time() with Time in BaseModel #6825

merged 2 commits into from
Nov 7, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 6, 2022

Description
See #6815

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 6, 2022
@kenjis kenjis mentioned this pull request Nov 6, 2022
Merged
3 tasks
@kenjis kenjis force-pushed the replace-time-in-BaseModel branch from 4b7a916 to 22fadc4 Compare November 7, 2022 07:44
@kenjis kenjis merged commit bc38d85 into codeigniter4:develop Nov 7, 2022
@kenjis kenjis deleted the replace-time-in-BaseModel branch November 7, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner