-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix PHPDoc and comments in Models #6822
Conversation
* | ||
* @return mixed | ||
* @return bool|string Returns a string if in test mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are annoying to support. I would like to see in v5 some kind of Database Proxy that passes requests through to the driver for most cases but "captures" the actual SQL query for Test Mode. I think that would be a much better approach than trying to adjust all our return types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the return types are not good, should be bool
only.
* | ||
* @param int|null $userData An optional PHP timestamp to be converted. | ||
* | ||
* @return mixed | ||
* @return int|string | ||
* | ||
* @throws ModelException | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent a PR #6825
Co-authored-by: MGatner <[email protected]>
What are these errors?
https://github.com/codeigniter4/CodeIgniter4/actions/runs/3404234441/jobs/5664964160 |
@paulbalandan Do you know anything?
|
Not sure, but can you try changing the extension to |
@paulbalandan Passed! |
Description
mixed
with more specific types #6310Checklist: