-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upsert + Refactor BaseBuilder *Batch() Methods #6407
Upsert + Refactor BaseBuilder *Batch() Methods #6407
Conversation
7ddeb54
to
cc0f38f
Compare
af34872
to
cc25ef4
Compare
cc25ef4
to
1423fda
Compare
This PR is too big (
The change in one commit is also so large that it is difficult to understand the code. So I think this PR is just a reference. |
Our PR guideline does not mention about commit messages well now. |
|
If we create special branch, can you send small PRs to it? |
I can try. A lot of the changes take place simultaneously. The only way I could properly plan and put it all together was to put it all together at once. There are things shared between upsert and update and there are things shared between upsert and insert. I had to put them all together to normalize these common things. Then refactor the methods that set and execute them. It would be a lot of piece work to try and do it one by one. I could summarize the major changes though. I had all the commits at one time but you complained there were too many so I merged them all together. |
There are a few things Id like to discuss with what is here. Once those things are figured out then I can rebuild it piece by piece if necessary. |
The old code was really screwy. Things were being set in all different places. Now there is one method to set data.. setBatch(). Any data that comes in through the other methods is referred to setBatch() |
Create a new branch for this and I will submit it in pieces and explain each piece. |
I don't recall complaining about too many PR commits, but maybe there was a problem with my English. I recommend atomic commits. Also, I would like the overall size of a PR to be small. |
Its best to review this code by looking at the code and not the "files changed". |
This PR is a combination of #6367 and #6373 as well as refactoring all the Batch methods.
This is the bigger picture of where those PR's are headed. You can consider this PR or not. Its hard to break things down much smaller because everything is interdependent.
I would suggest creating a special branch for upsert and refactor of Batch methods. Perhaps we could merge this PR there instead. This way we all may work together on it and contribute to it. I welcome any help!
This fixes #5674
Checklist: