Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QueryBuilder] *Batch() methods are inconsistant #6315

Closed
kenjis opened this issue Jul 29, 2022 · 2 comments
Closed

[QueryBuilder] *Batch() methods are inconsistant #6315

kenjis opened this issue Jul 29, 2022 · 2 comments
Labels
database Issues or pull requests that affect the database layer

Comments

@kenjis
Copy link
Member

kenjis commented Jul 29, 2022

set*Batch()

public function setInsertBatch($key, string $value = '', ?bool $escape = null);
public function setUpdateBatch($key, string $index = '', ?bool $escape = null);

setUpdateBatch() does not have $value.

*Batch()

public function insertBatch(?array $set = null, ?bool $escape = null, int $batchSize = 100);
public function updateBatch(?array $set = null, ?string $index = null, int $batchSize = 100);

updateBatch() does not have $escape.

References

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jul 30, 2022
@sclubricants
Copy link
Member

Related: #6407 #5149

@kenjis
Copy link
Member Author

kenjis commented Sep 27, 2022

Closed by #6536

@kenjis kenjis closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Development

No branches or pull requests

2 participants