-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make CLI::input()
testable
#6335
Conversation
e33c5f9
to
d787fe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with PHP stream registration. I think @paulbalandan has done a lot of our work in this area and might be able to review. The test use looks good and run was successful so I assume this is working as intended. 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have two occasions where I encountered stream wrappers (infection/include-interceptor
and dg/bypass-finals
) which I think won't mess with this php
wrapper since both are wrappers for the file
protocol.
I just have a few comments.
Last thing, should this class also have a public |
PHP manual says:
So I'm not sure we really need it, but I added it. |
6c24f32
to
3e2f780
Compare
Added docs. |
3e2f780
to
c4cefdb
Compare
dc9a285
to
2bf7753
Compare
Thanks you two, good stuff! |
Description
Fixes #6076
PhpStreamWrapper
CLI::input()
for testingChecklist: