Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot write test for CLI::prompt(), CLI::input() #6076

Closed
kenjis opened this issue Jun 5, 2022 · 1 comment
Closed

Cannot write test for CLI::prompt(), CLI::input() #6076

kenjis opened this issue Jun 5, 2022 · 1 comment
Assignees
@kenjis
Labels
dev

Comments

@kenjis
Copy link
Member

kenjis commented Jun 5, 2022

If we write test code for a command that uses CLI::prompt(), and run the test,
it waits for input for ever.

How can we write test?

CodeIgniter4/system/CLI/CLI.php

Line 181 in cf4641c

public static function input(?string $prefix = null): string

@kenjis kenjis changed the title Cannot write test for CLI::prompt() Cannot write test for CLI::prompt(), CLI::input() Jul 29, 2022
@kenjis kenjis mentioned this issue Jul 29, 2022
Merged
5 tasks
rivalarya added a commit to rivalarya/CodeIgniter4 that referenced this issue Jul 29, 2022
@rivalarya
- refactor code
c07de8e 
- delete unit test for promptByMultipleKeys because codeigniter4#6076
- change method name in docs and changelog
@kenjis kenjis added the dev label Aug 1, 2022
@kenjis kenjis self-assigned this Aug 3, 2022
@kenjis kenjis mentioned this issue Aug 3, 2022
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Aug 5, 2022

Fixed by #6335

@kenjis kenjis closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenjis kenjis

Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenjis