Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Property Types #6214

Merged
merged 9 commits into from
Jul 4, 2022
Merged

Config Property Types #6214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c66848f
Apply config property types
MGatner Jun 27, 2022
7eddfab
Apply CS Fixer
MGatner Jun 27, 2022
a2310ba
refactor: add type for properties
kenjis Jul 1, 2022
ca9f787
test: fix sessionSavePath values
kenjis Jul 1, 2022
e6c8e93
refactor: update config error checking
kenjis Jul 1, 2022
7c2fe75
config: update starter/app/Config/Paths.php
kenjis Jul 1, 2022
ff0ac55
fix: remove mistakenly reverted lines
kenjis Jul 2, 2022
6fd4d9c
docs: add user guide
kenjis Jul 2, 2022
8919482
docs: not union but atomic
kenjis Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions admin/starter/app/Config/Paths.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ class Paths
*
* This must contain the name of your "system" folder. Include
* the path if the folder is not in the same directory as this file.
*
* @var string
*/
public $systemDirectory = __DIR__ . '/../../vendor/codeigniter4/framework/system';
public string $systemDirectory = __DIR__ . '/../../vendor/codeigniter4/framework/system';

/**
* ---------------------------------------------------------------
Expand All @@ -38,10 +36,8 @@ class Paths
* you do, use a full server path.
*
* @see http://codeigniter.com/user_guide/general/managing_apps.html
*
* @var string
*/
public $appDirectory = __DIR__ . '/..';
public string $appDirectory = __DIR__ . '/..';

/**
* ---------------------------------------------------------------
Expand All @@ -53,21 +49,17 @@ class Paths
* need write permission to a single place that can be tucked away
* for maximum security, keeping it out of the app and/or
* system directories.
*
* @var string
*/
public $writableDirectory = __DIR__ . '/../../writable';
public string $writableDirectory = __DIR__ . '/../../writable';

/**
* ---------------------------------------------------------------
* TESTS DIRECTORY NAME
* ---------------------------------------------------------------
*
* This variable must contain the name of your "tests" directory.
*
* @var string
*/
public $testsDirectory = __DIR__ . '/../../tests';
public string $testsDirectory = __DIR__ . '/../../tests';

/**
* ---------------------------------------------------------------
Expand All @@ -78,8 +70,6 @@ class Paths
* contains the view files used by your application. By
* default this is in `app/Views`. This value
* is used when no value is provided to `Services::renderer()`.
*
* @var string
*/
public $viewDirectory = __DIR__ . '/../Views';
public string $viewDirectory = __DIR__ . '/../Views';
}
Loading