-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Property Types #6214
Config Property Types #6214
Conversation
admin appstarter seems needs update too
|
@samsonasik Good catch! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks @kenjis this looks great! So many PHPStan ignores cleaned up, that feels good.
Since the breaking change is entirely confined to mock classes I am fine with documenting that and proceeding. I think the likelihood of developers extending our mock classes is very slim, and it would only be in a test context. These classes probably should have been final
to begin with.
Approval conditional on updated documentation.
@MGatner The changes of the Mock Config classes break existing tests. But as you say,
So I would like to proceed to add the docs. |
app/Config/Routes.php
Outdated
// Load the system's routing file first, so that the app and ENVIRONMENT | ||
// can override as needed. | ||
if (is_file(SYSTEMPATH . 'Config/Routes.php')) { | ||
require SYSTEMPATH . 'Config/Routes.php'; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
Added User Guide. |
Description
Supersedes #6189
admin/starter/app/Config/Paths.php
Checklist: