fix: BaseModel::insert() may not pass all the values from Entity

[katie1348]

Fixes #4247

Updated the parameter passed, so the function behaves differently for Insert and Update, aligned with what would be expected.

Description
Added in a test to use all the fields when Inserting and to do a changed fields when Updating. The old version always only inserted changed fields, which is not what is expected.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

@katie1348 Your description says you added in a test but I don't see any in the PR. Are you able to add that?

[MichalPB1]

What is the status of? It also resolves my problem

[paulbalandan]

@MichalPB1 if you can help add a test for this change then it is mergeable.

[katie1348]

I would write a test, but I don't know how.

[kenjis]

See

• https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing
• https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/Models/InsertModelTest.php

[katie1348]

Hi Kenjis,

Thanks for the pointers and I have the system installed and the repo updated and cloned to my Mac.

When I run:

phpunit

I get the following error (stack trace omitted)

PHP Fatal error: Uncaught Error: Class "CodeIgniter\Models\LiveModelTestCase" not found in /Users/user/Sites/CodeIgniter4/tests/system/Models/AffectedRowsTest.php:19

I have no idea why a clean unchanged clone of the repo would throw up this error, any thoughts?

Thanks in advance.

[kenjis]

@katie1348 You maybe miss something.

This is how to:

$ git clone [email protected]:<your-name>/CodeIgniter4.git
$ cd CodeIgniter4/
$ composer install
$ vendor/bin/phpunit

[katie1348]

@kenjis Thank you for your help, much appreciated.

That now has it working, mostly. It fails some tests as I don't have Redis etc installed and will not. But it looks like it is up and running enough to write the necessary test.

Hopefully next week.

[kenjis]

@katie1348

You can run one test file:

$ vendor/bin/phpunit tests/system/HTTP/RequestTest.php

Or exclude live tests:

$ vendor/bin/phpunit --exclude-group DatabaseLive,CacheLive

[katie1348]

@kenjis

Once again, thank you for the assistance.

With your help, I have been able to get the test working and it is now ready for additional checking etc.

I am now stuck on the cs-fixer. I cannot seem to get it to run correctly. I have installed it with homebrew and it looks like it is working sometimes, but it does not seem to change the files.

When run from the command line, it get an error:

Fatal error: Uncaught Error: Class "Nexus\CsConfig\FixerGenerator" not found in /Users/user/Sites/CodeIgniter4/.php-cs-fixer.dist.php:52

I am once again stuck, your assistance would be appreciated.

[kenjis]

@katie1348 See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style

I have installed it with homebrew and it looks like it is working sometimes, but it does not seem to change the files.

This is a common mistake. We use php-cs-fixer for this project, and you have already installed it
via Composer.

And you can run with composer.

$ composer cs-fix

[katie1348]

@kenjis Thank you for that assistance. It got me over the hump.

OK, I have uploaded the changes to my fork, in the correct branch.

How do I go about getting the 6 Workflows awaiting approval to be run?

[kenjis]

How do I go about getting the 6 Workflows awaiting approval to be run?

You can't do anything. I approved.

[katie1348]

Updated to fix Reactor failures.

[katie1348]

@kenjis

Thanks for all your help in getting this done. I don't think I could have done it without you.

Is there anything else I need to do?

[kenjis]

@katie1348 I added review comments.
Please fix your test code.

If you have any questions, feel free to ask.

[katie1348]

Requested changes made.

[katie1348]

@kenjis I have accepted your changes to the tests.

[kenjis]

LGTM

[katie1348]

@kenjis Thanks for all your help and patience.

[paulbalandan]

Also, please squash before merging to remove the merge commit.

[kenjis]

@katie1348 Congratulations! You are now a contributor to this project. 🎉

[MGatner]

Thanks all for the work! Sorry this one sat so long, looks like a quality PR - just slipped through the cracks.

[katie1348]

@katie1348 Congratulations! You are now a contributor to this project. 🎉

Only because you did all the hand holding I needed. Thank you once again.