Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of BaseModel.php to fix INSERT issue #4979

Conversation

katie1348
Copy link
Contributor

Applied the fix that enables the INSERT to work correctly when inserting a row that already contains data.

Each pull request should address a single issue and have a meaningful title.

Description
Applied the fix suggested by @arbitmcdonald in Bug: onlyChanged is currently true for INSERT #4247

Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Applied the fix that enables the INSERT to work correctly when inserting a row that already contains data.
@paulbalandan
Copy link
Member

We would need tests to verify that the fix is actually working.

@paulbalandan
Copy link
Member

You can take at a look at tests/system/Models/ dir to check the tests for the Model.

@katie1348
Copy link
Contributor Author

OK, so it looks like the error is a coding standards error of == rather than ===.

Does his mean I need to start the process from the beginning to make this change?

@paulbalandan
Copy link
Member

No need to open new PR. You can do the edit directly here.

@paulbalandan
Copy link
Member

Replaced by #4980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants