-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Security Class #3961
Refactor Security Class #3961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor is good to me but we need the review of others since this is a major component of the framework. Some notes:
- Fix the user guide syntax check
- In the main Security class, you cannot rename or remove the public and protected methods as it would mean a BC break for people using those. The deprecations and detours for the renamed Security methods are good though.
- See other comments below.
This looks great! I'm a fan of splitting these out, you've been doing a great job with it. I'd like to give this one more look when I'm not on mobile (or have someone else's review) but let's plan to include this in 4.1 so these deprecations can get entered. |
Is there any merit to merging this and ContentSecurityPolicy config? I'm not terribly knowledgeable of the various security components but as a novice having all "security" under one Config seems logical? |
While ContentSecurityPolicy config serve HTTP\ContentSecurityPolicy class, and Security config serve Security\Security class, I think there is no point in merging them together at least for now. |
I think this looks good also. @MGatner are we good to merge this into 4.0.5 or should this be a 4.1 change? It looks like everything is deprecated and BC safe. |
@lonnieezell I think this is fine for 4.0.5. Since we decided to support PHP 8 in 4.0.5 the only real rubric for 4.1 is support for PHP 7.2. |
Creates new Config\Security class and make \CodeIgniter\Security\Security class depends on it
removes useless properties
rename some properties
rename some methods
add new public methods:
edits changes in user guide
Closes #3836