Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Security Configuration #3836

Closed
wants to merge 27 commits into from

Conversation

mostafakhudair
Copy link
Contributor

@mostafakhudair mostafakhudair commented Oct 30, 2020

Creates new Config\Security class and make \CodeIgniter\Security\Security class depends on it

removes useless properties
rename some properties

rename some methods

CSRFVerify() to verify()
getCSRFHash() to getHash()
getCSRFTokenName() to getTokenName()
setHash() to generateHash()

add new public methods:

getHeaderName()
getCookieName()
isExpired()
shouldRedirect()

edits changes in user guide

  • Securely signed commits
  • Component(s) with PHPdocs
  • User guide updated
  • Conforms to style guide

Closes #3703

@mostafakhudair
Copy link
Contributor Author

All green

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 1, 2020
@paulbalandan
Copy link
Member

  • Please squash commits 9ff90b9 to 6ab17ef.
  • Squash commits 9df259b to 2bb5089.

We're now implementing a clean, descriptive commit history to help in changelog generation.

@mostafakhudair mostafakhudair marked this pull request as draft December 1, 2020 17:20
@mostafakhudair
Copy link
Contributor Author

I'm working on it

@mostafakhudair mostafakhudair deleted the patch-7 branch December 4, 2020 07:04
@mostafakhudair mostafakhudair mentioned this pull request Dec 4, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants