Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply PHP 8 compatibility changes #3947

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Apply PHP 8 compatibility changes #3947

merged 2 commits into from
Dec 1, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 30, 2020

Description
Fixes the test failures identified by #3932

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner @mostafakhudair
Consolidate message
ffbe318 
Co-authored-by: Mostafa Khudair <[email protected]>
lonnieezell
lonnieezell approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge at will. (Poor Will)

@MGatner MGatner merged commit 0d62b8a into codeigniter4:develop Dec 1, 2020
@MGatner MGatner deleted the tweak-8 branch December 1, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafakhudair mostafakhudair mostafakhudair left review comments

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MGatner @lonnieezell @mostafakhudair