Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Action workflows #3932

Closed
wants to merge 16 commits into from
Closed

PHP 8 Action workflows #3932

wants to merge 16 commits into from

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 27, 2020 •
edited
Loading

Description
Enables PHP 8 in the relevant CI workflows. This PR will require #3938 and a rebase before being close to passing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner changed the base branch from develop to 4.1 November 27, 2020 16:15
@MGatner
Copy link
Member Author

MGatner commented Nov 28, 2020

This is awaiting #3940 and another rebase of 4.1 to resolve the Autoloader merge.

samsonasik and others added 13 commits November 30, 2020 01:57
@samsonasik @MGatner
4.1.0: remove Autoloader::loadLegacy() method
f25442f
@samsonasik @paulbalandan @MGatner
Update grammar user_guide_src/source/changelogs/v4.1.0.rst
a7b39b7 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@samsonasik @MGatner
4.1.0 : remove deprecated Model::fillPlaceholders()
7aaa4c4
@samsonasik @MGatner
add changelog 4.1.0 for removal Model::fillPlaceholders()
191127b
@MGatner
Bump PHP req, PHPUnit version
dd00333
@MGatner
Migrate PHPUnit to 9
0b0fc00
@MGatner
Update various references to 7.2
58f3904
@MGatner
Improve XML formatting
01d2794
@MGatner
Fix additional ersion reference
5cce566
@MGatner
Fix toctree
9f58c59
@samsonasik @MGatner
[4.1] Remove Skip UnderscoreToCamelCaseVariableNameRector for Autoloa…
b3b174c 
…der.php file

Previously, in `develop`, it skipped due conflict with deprecated code. In 4.1, deprecated code is removed.
@paulbalandan @MGatner
Change deprecated assertFileNotExists
a42334a
@MGatner
Backfill misplaced mandatory arguments
731478d
@MGatner MGatner mentioned this pull request Nov 30, 2020
Merged
4 tasks
@MGatner
Copy link
Member Author

MGatner commented Nov 30, 2020 

✗ imagick Could not install imagick on PHP 8.0.0
✗ sqlsrv Could not install sqlsrv on PHP 8.0.0

Supposedly imagick should be working for PHP 8.0 so I'm not sure why it is not installing? shivammathur/setup-php#320

@MGatner
Copy link
Member Author

MGatner commented Nov 30, 2020 •
edited
Loading

imagick is not on the supported list for 8.0 (https://github.com/shivammathur/setup-php/wiki/Php-extensions-on-ubuntu-20.04#php-80) but it also isn't on the 7.4 list so maybe that just has not been updated?

EDIT: This was my misunderstanding, that was the list of default extensions.

@MGatner
Copy link
Member Author

MGatner commented Nov 30, 2020

Ref. shivammathur/setup-php#353

@MGatner
Copy link
Member Author

MGatner commented Dec 6, 2020

Since 4.0.5 is now officially going to support PHP 8 this should be redirected to develop and resolved there.

@MGatner MGatner changed the base branch from 4.1 to develop December 21, 2020 17:49
@MGatner MGatner mentioned this pull request Dec 21, 2020
Merged
3 tasks
@MGatner
Copy link
Member Author

MGatner commented Dec 21, 2020

Starting afresh.

@MGatner MGatner closed this Dec 21, 2020
@MGatner MGatner deleted the 4.1-workflows branch December 21, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MGatner @paulbalandan @samsonasik