Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session id validation when using php7.1 #372

Merged
merged 8 commits into from
Jan 19, 2017
Merged

session id validation when using php7.1 #372

merged 8 commits into from
Jan 19, 2017

Conversation

byazrail
Copy link
Contributor

@byazrail byazrail commented Jan 18, 2017 •
edited
Loading

Hi :)
issue bug #371
Workaround, according to the new system.

reference ;
bcit-ci/CodeIgniter@2f76087

@byazrail byazrail changed the title session id validation when using php7.1 #371 session id validation when using php7.1 Jan 18, 2017
@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 61.44% when pulling 7e07cb9 on byazrail:develop into e69777b on bcit-ci:develop.

@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 61.91% when pulling 1acaa67 on byazrail:develop into 0634ac6 on bcit-ci:develop.

@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 61.91% when pulling 1acaa67 on byazrail:develop into 0634ac6 on bcit-ci:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 61.91% when pulling 5beecd7 on byazrail:develop into 0634ac6 on bcit-ci:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 61.91% when pulling 5beecd7 on byazrail:develop into 0634ac6 on bcit-ci:develop.

@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 61.914% when pulling c198b06 on byazrail:develop into 0634ac6 on bcit-ci:develop.

@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 62.013% when pulling cab349e on byazrail:develop into 0634ac6 on bcit-ci:develop.

@lonnieezell
Copy link
Member

Looks good. Thanks!

@lonnieezell lonnieezell merged commit b4bc813 into codeigniter4:develop Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byazrail @coveralls @lonnieezell