Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session id validation when using php7.1 #371

Closed
HunterXuan opened this issue Jan 17, 2017 · 5 comments
Closed

session id validation when using php7.1 #371

HunterXuan opened this issue Jan 17, 2017 · 5 comments

Comments

@HunterXuan
Copy link

HunterXuan commented Jan 17, 2017

Regex: /^[0-9a-f]{40}$/ is not working correctly when using php 7.1. According to php manual (http://php.net/manual/en/session.configuration.php#ini.session.sid-length), these values should be set as follow
session.sid_length = 40
session.sid_bits_per_character = 4

In my case, session file regenerated for every request, when FileHandler was used as session driver, and
session.sid_length = 32
session.sid_bits_per_character = 5

@byazrail
Copy link
Contributor

Adapter, redis etc. are have bugs.

@lonnieezell
Copy link
Member

Can you guys provide specifics about what you're seeing happening, what your setup is, etc. I need more details than, "It's not working" :)

@byazrail
Copy link
Contributor

byazrail commented Jan 17, 2017

Hi :)
Workaround, according to the new system;
fix ; byazrail@14ed8d9

reference ;
bcit-ci/CodeIgniter@2f76087

@lonnieezell
Copy link
Member

@byazrail That's great. Thanks. Could you submit that as a pull request?

I did see something about those issues coming to light, but didn't follow it close enough, obviously. :)

@byazrail
Copy link
Contributor

@lonnieezell welcome, submitted as pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants