Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for session and mock fixes #3552

Merged
merged 2 commits into from
Aug 27, 2020
Merged

More tests for session and mock fixes #3552

merged 2 commits into from
Aug 27, 2020

Conversation

michalsn
Copy link
Member

Description
This PR adds more tests for a Session class and fixes some MockSession issues.

Ref: #3543, #3546

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • Conforms to style guide

MGatner
MGatner approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this represents our first explicit test split on versions.

@MGatner MGatner merged commit da6da01 into codeigniter4:develop Aug 27, 2020
@michalsn
Copy link
Member Author

Yes, I believe that tests for Session class are the only place where we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @MGatner